From: Michael Kelley <mhklinux@outlook.com>
To: Juergen Gross <jgross@suse.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Cc: Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Sean Christopherson <seanjc@google.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH v6 03/17] x86/msr: Minimize usage of native_*() msr access functions
Date: Tue, 17 Nov 2026 04:52:49 +0000 [thread overview]
Message-ID: <MN2PR02MB686321E2F5042F532F9E76C0D47B2@MN2PR02MB6863.namprd02.prod.outlook.com> (raw)
In-Reply-To: <20261116183905.1591611-4-jgross@suse.com>
From: Juergen Gross <jgross@suse.com> Sent: Monday, November 16, 2026 10:39 AM
>
> In order to prepare for some MSR access function reorg work, switch
> most users of native_{read|write}_msr[_safe]() to the more generic
> rdmsr*()/wrmsr*() variants.
>
> For now this will have some intermediate performance impact with
> paravirtualization configured when running on bare metal, but this
> is a prereq change for the planned direct inlining of the rdmsr/wrmsr
> instructions with this configuration.
>
> The main reason for this switch is the planned move of the MSR trace
> function invocation from the native_*() functions to the generic
> rdmsr*()/wrmsr*() variants. Without this switch the users of the
> native_*() functions would lose the related tracing entries.
>
> Note that the Xen related MSR access functions will not be switched,
> as these will be handled after the move of the trace hooks.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Acked-by: Sean Christopherson <seanjc@google.com>
> Acked-by: Wei Liu <wei.liu@kernel.org>
> Reviewed-by: H. Peter Anvin (Intel) <hpa@zytor.com>
> ---
> arch/x86/hyperv/ivm.c | 2 +-
> arch/x86/kernel/cpu/mshyperv.c | 4 ++--
For these two Hyper-V related files,
Reviewed-by: Michael Kelley <mhklinux@outlook.com>
> arch/x86/kernel/kvmclock.c | 2 +-
> arch/x86/kvm/svm/svm.c | 16 ++++++++--------
> arch/x86/xen/pmu.c | 4 ++--
> 5 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c
> index 2ce4dfe53472..a74f121f2a02 100644
> --- a/arch/x86/hyperv/ivm.c
> +++ b/arch/x86/hyperv/ivm.c
> @@ -328,7 +328,7 @@ int hv_snp_boot_ap(u32 apic_id, unsigned long start_ip,
> unsigned int cpu)
> savesegment(ds, vmsa->ds.selector);
> hv_populate_vmcb_seg(vmsa->ds, vmsa->gdtr.base);
>
> - vmsa->efer = native_read_msr(MSR_EFER);
> + vmsa->efer = rdmsrq(MSR_EFER);
>
> vmsa->cr4 = native_read_cr4();
> vmsa->cr3 = __native_read_cr3();
> diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
> index 91bbffbf5412..eab5516bc243 100644
> --- a/arch/x86/kernel/cpu/mshyperv.c
> +++ b/arch/x86/kernel/cpu/mshyperv.c
> @@ -114,7 +114,7 @@ u64 hv_para_get_synic_register(unsigned int reg)
> {
> if (WARN_ON(!ms_hyperv.paravisor_present || !hv_is_synic_msr(reg)))
> return ~0ULL;
> - return native_read_msr(reg);
> + return rdmsrq(reg);
> }
>
> /*
> @@ -124,7 +124,7 @@ void hv_para_set_synic_register(unsigned int reg, u64 val)
> {
> if (WARN_ON(!ms_hyperv.paravisor_present || !hv_is_synic_msr(reg)))
> return;
> - native_write_msr(reg, val);
> + wrmsrq(reg, val);
> }
>
> u64 hv_get_msr(unsigned int reg)
> diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
> index cb3d0ca1fa22..6ddef8b5426a 100644
> --- a/arch/x86/kernel/kvmclock.c
> +++ b/arch/x86/kernel/kvmclock.c
> @@ -219,7 +219,7 @@ static void kvm_setup_secondary_clock(void)
> void kvmclock_disable(void)
> {
> if (msr_kvm_system_time)
> - native_write_msr(msr_kvm_system_time, 0);
> + wrmsrq(msr_kvm_system_time, 0);
> }
>
> static void __init kvmclock_init_mem(void)
> diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
> index a432b878c683..64f609d1ee59 100644
> --- a/arch/x86/kvm/svm/svm.c
> +++ b/arch/x86/kvm/svm/svm.c
> @@ -415,12 +415,12 @@ static void svm_init_erratum_383(void)
> return;
>
> /* Use _safe variants to not break nested virtualization */
> - if (native_read_msr_safe(MSR_AMD64_DC_CFG, &val))
> + if (rdmsrq_safe(MSR_AMD64_DC_CFG, &val))
> return;
>
> val |= (1ULL << 47);
>
> - native_write_msr_safe(MSR_AMD64_DC_CFG, val);
> + wrmsrq_safe(MSR_AMD64_DC_CFG, val);
>
> erratum_383_found = true;
> }
> @@ -473,8 +473,8 @@ static void svm_init_os_visible_workarounds(void)
> return;
>
> if (!this_cpu_has(X86_FEATURE_OSVW) ||
> - native_read_msr_safe(MSR_AMD64_OSVW_ID_LENGTH, &len) ||
> - native_read_msr_safe(MSR_AMD64_OSVW_STATUS, &status))
> + rdmsrq_safe(MSR_AMD64_OSVW_ID_LENGTH, &len) ||
> + rdmsrq_safe(MSR_AMD64_OSVW_STATUS, &status))
> len = status = 0;
>
> if (status == READ_ONCE(osvw_status) && len >= READ_ONCE(osvw_len))
> @@ -2156,7 +2156,7 @@ static bool is_erratum_383(void)
> if (!erratum_383_found)
> return false;
>
> - if (native_read_msr_safe(MSR_IA32_MC0_STATUS, &value))
> + if (rdmsrq_safe(MSR_IA32_MC0_STATUS, &value))
> return false;
>
> /* Bit 62 may or may not be set for this mce */
> @@ -2167,11 +2167,11 @@ static bool is_erratum_383(void)
>
> /* Clear MCi_STATUS registers */
> for (i = 0; i < 6; ++i)
> - native_write_msr_safe(MSR_IA32_MCx_STATUS(i), 0);
> + wrmsrq_safe(MSR_IA32_MCx_STATUS(i), 0);
>
> - if (!native_read_msr_safe(MSR_IA32_MCG_STATUS, &value)) {
> + if (!rdmsrq_safe(MSR_IA32_MCG_STATUS, &value)) {
> value &= ~(1ULL << 2);
> - native_write_msr_safe(MSR_IA32_MCG_STATUS, value);
> + wrmsrq_safe(MSR_IA32_MCG_STATUS, value);
> }
>
> /* Flush tlb to evict multi-match entries */
> diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
> index 3f4dd3f50f56..25f434b6b903 100644
> --- a/arch/x86/xen/pmu.c
> +++ b/arch/x86/xen/pmu.c
> @@ -324,7 +324,7 @@ static u64 xen_amd_read_pmc(int counter)
> u64 val;
>
> msr = amd_counters_base + (counter * amd_msr_step);
> - native_read_msr_safe(msr, &val);
> + rdmsrq_safe(msr, &val);
> return val;
> }
>
> @@ -350,7 +350,7 @@ static u64 xen_intel_read_pmc(int counter)
> else
> msr = MSR_IA32_PERFCTR0 + counter;
>
> - native_read_msr_safe(msr, &val);
> + rdmsrq_safe(msr, &val);
> return val;
> }
>
> --
> 2.56.0
>
next prev parent reply other threads:[~2026-11-17 4:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 18:38 [PATCH v6 00/17] x86/msr: Inline rdmsr/wrmsr instructions Juergen Gross
2026-11-16 18:38 ` [PATCH v6 01/17] x86/alternative: Support alt_replace_call() with instructions after call Juergen Gross
2026-11-16 18:38 ` [PATCH v6 02/17] coco/tdx: Rename MSR access helpers Juergen Gross
2026-11-16 18:38 ` [PATCH v6 03/17] x86/msr: Minimize usage of native_*() msr access functions Juergen Gross
2026-11-17 4:52 ` Michael Kelley [this message]
2026-11-16 18:38 ` [PATCH v6 04/17] x86/msr: Move MSR trace calls one function level up Juergen Gross
2026-11-16 18:38 ` [PATCH v6 05/17] x86/hyperv: Switch from __rdmsr() to native_rdmsrq() Juergen Gross
2026-11-17 4:52 ` Michael Kelley
2026-11-16 18:38 ` [PATCH v6 06/17] x86/opcode: Add immediate form MSR instructions Juergen Gross
2026-11-16 18:38 ` [PATCH v6 07/17] x86/extable: Add support for " Juergen Gross
2026-11-16 18:38 ` [PATCH v6 08/17] x86/msr: Make wrmsrns() a first class citizen Juergen Gross
2026-11-16 18:38 ` [PATCH v6 09/17] x86/msr: Introduce sync_cpu_after_wrmsrns() Juergen Gross
2026-11-16 18:38 ` [PATCH v6 10/17] x86/msr: Use the alternatives mechanism for RDMSR Juergen Gross
2026-11-16 18:38 ` [PATCH v6 11/17] x86/alternatives: Add ALTERNATIVE_4() Juergen Gross
2026-11-16 18:39 ` [PATCH v6 12/17] x86/paravirt: Split off MSR related hooks into new header Juergen Gross
2026-11-16 18:39 ` [PATCH v6 13/17] x86/paravirt: Prepare support of MSR instruction interfaces Juergen Gross
2026-11-16 18:39 ` [PATCH v6 14/17] x86/paravirt: Switch MSR access pv_ops functions to " Juergen Gross
2026-11-16 18:39 ` [PATCH v6 15/17] x86/msr: Reduce number of low level MSR access helpers Juergen Gross
2026-11-16 18:39 ` [PATCH v6 16/17] x86/paravirt: Use alternatives for MSR access with paravirt Juergen Gross
2026-11-16 18:39 ` [PATCH v6 17/17] x86/msr: Make all MSR access functions __always_inline Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR02MB686321E2F5042F532F9E76C0D47B2@MN2PR02MB6863.namprd02.prod.outlook.com \
--to=mhklinux@outlook.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kvm@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@kernel.org \
--cc=vkuznets@redhat.com \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®