mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Kelley <mhklinux@outlook.com>
To: Daniel Pereira <danielmaraboo@gmail.com>,
	"mhkelley58@gmail.com" <mhkelley58@gmail.com>
Cc: "haiyangz@microsoft.com" <haiyangz@microsoft.com>,
	"wei.liu@kernel.org" <wei.liu@kernel.org>,
	"decui@microsoft.com" <decui@microsoft.com>,
	"corbet@lwn.net" <corbet@lwn.net>,
	"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>,
	"rdunlap@infradead.org" <rdunlap@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: RE: [PATCH 1/1] Documentation: hyperv: Update docs for PCI pass-thru device support
Date: Tue, 3 Nov 2026 04:50:48 +0000	[thread overview]
Message-ID: <MN2PR02MB68638712B3DECB1C25FDD5A0D4692@MN2PR02MB6863.namprd02.prod.outlook.com> (raw)
In-Reply-To: <CAMAsx6eCrbcseb=eM_GW+3k2YF3t38Was35oQHW+3UkidsvKWA@mail.gmail.com>

From: Daniel Pereira <danielmaraboo@gmail.com> Sent: Monday, November 2, 2026 6:12 PM
> 
> Hi !
> 
> > +and unmask interrupts. It becomes the parent domain for the per
> > +device IRQ domain created by the normal Linux driver for the
> 
> I think "per-device" should have a hyphen here too, since it's an adjective.
> 
> > +"irqchip@<paddr>" domain created by the GICv3 driver when it
> > +initiaizes the virtual GICv3 hardware provided to the guest
> 
> Is "initiaizes" a typo? Shouldn't it be "initializes"?
> 
> > +device's MSI/MSI-X registers/tables. The guest writes a virutal
> 
> I think this one is also a typo, right? Shouldn't it be "virtual"?
> 
> > +Once the host-valid MSI message is obtained, the guest must treat it
> > +as a black-box that the guest does not interpret or modify. The only
> 
> "black box" (no hyphen) it's used as a noun here, so it shouldn't be hyphenated.
> 
> > +valid guest action is to write it to the MSI/MSI-X registers/tables
> > +using the .irq_chip_write_msi_msg function on the HV-PCI-MSIX-<PCIaddr>
> 
> struct irq_chip has no .irq_chip_write_msi_msg; shouldn't this be
> .irq_write_msi_msg? Same in the last paragraph.
> 

Thanks for the careful review! Yes, these are typos and hypenation
errors that I'll fix in v2.

Michael

  reply	other threads:[~2026-11-03  4:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-01  2:22 Michael Kelley
2026-11-03  2:12 ` Daniel Pereira
2026-11-03  4:50   ` Michael Kelley [this message]
2026-11-03  8:42 ` Naman Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR02MB68638712B3DECB1C25FDD5A0D4692@MN2PR02MB6863.namprd02.prod.outlook.com \
    --to=mhklinux@outlook.com \
    --cc=corbet@lwn.net \
    --cc=danielmaraboo@gmail.com \
    --cc=decui@microsoft.com \
    --cc=haiyangz@microsoft.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhkelley58@gmail.com \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=wei.liu@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®