From: Liming Sun <limings@nvidia.com>
To: Vadim Pasternak <vadimp@nvidia.com>,
Andy Shevchenko <andy@infradead.org>,
Darren Hart <dvhart@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>
Subject: RE: [PATCH v1 1/1] platform/mellanox: mlxbf-tmfifo: Fix a memory barrier issue
Date: Sat, 8 May 2021 00:14:52 +0000 [thread overview]
Message-ID: <MN2PR12MB3565DB8F08395AA14226AF9CD3569@MN2PR12MB3565.namprd12.prod.outlook.com> (raw)
In-Reply-To: <DM6PR12MB389868EDF9F7B1607E6E1BF0AF579@DM6PR12MB3898.namprd12.prod.outlook.com>
Thanks!
Sure, I'll resent it as bugfix in v2.
> -----Original Message-----
> From: Vadim Pasternak <vadimp@nvidia.com>
> Sent: Friday, May 7, 2021 11:39 AM
> To: Liming Sun <limings@nvidia.com>; Andy Shevchenko
> <andy@infradead.org>; Darren Hart <dvhart@infradead.org>
> Cc: linux-kernel@vger.kernel.org; platform-driver-x86@vger.kernel.org
> Subject: RE: [PATCH v1 1/1] platform/mellanox: mlxbf-tmfifo: Fix a memory
> barrier issue
>
>
>
> > -----Original Message-----
> > From: Liming Sun <limings@nvidia.com>
> > Sent: Friday, May 7, 2021 6:19 PM
> > To: Andy Shevchenko <andy@infradead.org>; Darren Hart
> > <dvhart@infradead.org>; Vadim Pasternak <vadimp@nvidia.com>
> > Cc: Liming Sun <limings@nvidia.com>; linux-kernel@vger.kernel.org;
> > platform-driver-x86@vger.kernel.org
> > Subject: [PATCH v1 1/1] platform/mellanox: mlxbf-tmfifo: Fix a memory
> > barrier issue
> >
> > The virtio framework uses wmb() when updating avail->idx. It guarantees
> > the write order, but not necessarily loading order for the code accessing
> the
> > memory. This commit adds a load barrier after reading the avail->idx to
> make
> > sure all the data in the descriptor is visible. It also adds a barrier when
> > returning the packet to virtio framework to make sure read/writes are
> visible
> > to the virtio code.
>
> I suppose it should be sent as Bugfix?
>
> >
> > Signed-off-by: Liming Sun <limings@nvidia.com>
> > ---
> > drivers/platform/mellanox/mlxbf-tmfifo.c | 11 ++++++++++-
> > 1 file changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c
> > b/drivers/platform/mellanox/mlxbf-tmfifo.c
> > index bbc4e71..38800e8 100644
> > --- a/drivers/platform/mellanox/mlxbf-tmfifo.c
> > +++ b/drivers/platform/mellanox/mlxbf-tmfifo.c
> > @@ -294,6 +294,9 @@ static irqreturn_t mlxbf_tmfifo_irq_handler(int irq,
> > void *arg)
> > if (vring->next_avail == virtio16_to_cpu(vdev, vr->avail->idx))
> > return NULL;
> >
> > + /* Make sure 'avail->idx' is visible already. */
> > + virtio_rmb(false);
> > +
> > idx = vring->next_avail % vr->num;
> > head = virtio16_to_cpu(vdev, vr->avail->ring[idx]);
> > if (WARN_ON(head >= vr->num))
> > @@ -322,7 +325,7 @@ static void mlxbf_tmfifo_release_desc(struct
> > mlxbf_tmfifo_vring *vring,
> > * done or not. Add a memory barrier here to make sure the update
> > above
> > * completes before updating the idx.
> > */
> > - mb();
> > + virtio_mb(false);
> > vr->used->idx = cpu_to_virtio16(vdev, vr_idx + 1); }
> >
> > @@ -733,6 +736,12 @@ static bool mlxbf_tmfifo_rxtx_one_desc(struct
> > mlxbf_tmfifo_vring *vring,
> > desc = NULL;
> > fifo->vring[is_rx] = NULL;
> >
> > + /*
> > + * Make sure the load/store are in order before
> > + * returning back to virtio.
> > + */
> > + virtio_mb(false);
> > +
> > /* Notify upper layer that packet is done. */
> > spin_lock_irqsave(&fifo->spin_lock[is_rx], flags);
> > vring_interrupt(0, vring->vq);
> > --
> > 1.8.3.1
next prev parent reply other threads:[~2021-05-08 0:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 15:19 Liming Sun
2021-05-07 15:38 ` Vadim Pasternak
2021-05-08 0:14 ` Liming Sun [this message]
2021-05-08 0:30 ` [PATCH v2] " Liming Sun
2021-05-08 9:01 ` Hans de Goede
2021-05-08 11:22 ` Vadim Pasternak
2021-05-19 13:19 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB3565DB8F08395AA14226AF9CD3569@MN2PR12MB3565.namprd12.prod.outlook.com \
--to=limings@nvidia.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®