mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sudarsana Reddy Kalluru <skalluru@marvell.com>
To: Igor Russkikh <irusskikh@marvell.com>,
	Vaibhav Gupta <vaibhavgupta40@gmail.com>,
	Bjorn Helgaas <helgaas@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"bjorn@helgaas.com" <bjorn@helgaas.com>,
	Vaibhav Gupta <vaibhav.varodek@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	Ariel Elior <aelior@marvell.com>,
	GR-everest-linux-l2 <GR-everest-linux-l2@marvell.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kernel-mentees@lists.linuxfoundation.org" 
	<linux-kernel-mentees@lists.linuxfoundation.org>,
	"skhan@linuxfoundation.org" <skhan@linuxfoundation.org>
Subject: RE: [EXT] [PATCH v1] bnx2x: use generic power management
Date: Fri, 26 Jun 2020 10:15:52 +0000	[thread overview]
Message-ID: <MN2PR18MB2528DB31A7C55B0D69E7FF0ED3930@MN2PR18MB2528.namprd18.prod.outlook.com> (raw)
In-Reply-To: <f685dfe2-9a50-15f5-f94f-c72433f84eb1@marvell.com>


> -----Original Message-----
> From: Igor Russkikh <irusskikh@marvell.com>
> Sent: Thursday, June 25, 2020 10:16 PM
> To: Vaibhav Gupta <vaibhavgupta40@gmail.com>; Bjorn Helgaas
> <helgaas@kernel.org>; Bjorn Helgaas <bhelgaas@google.com>;
> bjorn@helgaas.com; Vaibhav Gupta <vaibhav.varodek@gmail.com>; David S.
> Miller <davem@davemloft.net>; Jakub Kicinski <kuba@kernel.org>; Ariel Elior
> <aelior@marvell.com>; Sudarsana Reddy Kalluru <skalluru@marvell.com>; GR-
> everest-linux-l2 <GR-everest-linux-l2@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; linux-kernel-
> mentees@lists.linuxfoundation.org; skhan@linuxfoundation.org
> Subject: Re: [EXT] [PATCH v1] bnx2x: use generic power management
> 
> 
> 
> On 24/06/2020 8:51 pm, Vaibhav Gupta wrote:
> > External Email
> >
> > ----------------------------------------------------------------------
> > With legacy PM, drivers themselves were responsible for managing the
> > device's power states and takes care of register states.
> >
> > After upgrading to the generic structure, PCI core will take care of
> > required tasks and drivers should do only device-specific operations.
> >
> > The driver was also calling bnx2x_set_power_state() to set the power
> > state of the device by changing the device's registers' value. It is
> > no more needed.
> >
> > Compile-tested only.
> >
> > Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>
> > ---
> >  drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c  | 15 ++++++---------
> > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h  |  4 +---
> > drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |  3 +--
> >  3 files changed, 8 insertions(+), 14 deletions(-)
> 
> Acked-by: Igor Russkikh <irusskikh@marvell.com>
> 
> Sudarsana, could you please give it a short sanity test and report back?
> 
> Thanks,
>   Igor

I have run the basic sanity test with these changes in the driver, didn’t see any issues.

Thanks,
Sudarsana

  reply	other threads:[~2020-06-26 10:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-24 17:51 Vaibhav Gupta
2020-06-25 16:46 ` [EXT] " Igor Russkikh
2020-06-26 10:15   ` Sudarsana Reddy Kalluru [this message]
2020-06-26 19:14 ` David Miller
2020-06-27  5:50   ` Vaibhav Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR18MB2528DB31A7C55B0D69E7FF0ED3930@MN2PR18MB2528.namprd18.prod.outlook.com \
    --to=skalluru@marvell.com \
    --cc=GR-everest-linux-l2@marvell.com \
    --cc=aelior@marvell.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn@helgaas.com \
    --cc=davem@davemloft.net \
    --cc=helgaas@kernel.org \
    --cc=irusskikh@marvell.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=vaibhav.varodek@gmail.com \
    --cc=vaibhavgupta40@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®