From: "Elliott, Robert (Servers)" <elliott@hpe.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
Babis Chalios <bchalios@amazon.es>
Cc: Olivia Mackall <olivia@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Jason Wang <jasowang@redhat.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"amit@kernel.org" <amit@kernel.org>,
"graf@amazon.de" <graf@amazon.de>,
"Jason@zx2c4.com" <Jason@zx2c4.com>,
"xmarcalx@amazon.co.uk" <xmarcalx@amazon.co.uk>
Subject: RE: [PATCH 1/2] virtio-rng: implement entropy leak feature
Date: Fri, 20 Jan 2023 15:07:08 +0000 [thread overview]
Message-ID: <MW5PR84MB18426587FD27BB152D621BABABC59@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20230120072909-mutt-send-email-mst@kernel.org>
> > +#include "asm-generic/errno.h"
>
> Why are you pulling this in?
> If you really need errno the thing to include
> is linux/errno.h
>
> checkpatch has a rule to catch such cases:
>
> # warn if <asm/foo.h> is #included and <linux/foo.h> is available and includes
> # itself <asm/foo.h> (uses RAW line)
It's only looking for asm, not variations like asm-generic.
next prev parent reply other threads:[~2023-01-20 15:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 18:43 [PATCH 0/2] [RFC] virtio-rng entropy leak reporting feature Babis Chalios
2023-01-19 18:43 ` [PATCH 1/2] virtio-rng: implement entropy leak feature Babis Chalios
2023-01-19 20:17 ` kernel test robot
2023-01-20 1:24 ` kernel test robot
2023-01-20 12:32 ` Michael S. Tsirkin
2023-01-20 12:54 ` Babis Chalios
2023-01-20 15:07 ` Elliott, Robert (Servers) [this message]
2023-01-19 18:43 ` [PATCH 2/2] virtio-rng: add sysfs entries for leak detection Babis Chalios
2023-01-19 22:31 ` kernel test robot
2023-01-19 22:51 ` kernel test robot
2023-01-20 3:07 ` kernel test robot
2023-01-20 14:20 ` [PATCH 0/2] [RFC] virtio-rng entropy leak reporting feature Jason A. Donenfeld
2023-01-20 14:27 ` bchalios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW5PR84MB18426587FD27BB152D621BABABC59@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM \
--to=elliott@hpe.com \
--cc=Jason@zx2c4.com \
--cc=amit@kernel.org \
--cc=bchalios@amazon.es \
--cc=graf@amazon.de \
--cc=herbert@gondor.apana.org.au \
--cc=jasowang@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=olivia@selenic.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xmarcalx@amazon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®