From: "Elliott, Robert (Servers)" <elliott@hpe.com>
To: Lino Sanfilippo <l.sanfilippo@kunbus.com>,
"jarkko@kernel.org" <jarkko@kernel.org>,
"peterhuewe@gmx.de" <peterhuewe@gmx.de>
Cc: "LinoSanfilippo@gmx.de" <LinoSanfilippo@gmx.de>,
"p.rosenberger@kunbus.com" <p.rosenberger@kunbus.com>,
"lukas@wunner.de" <lukas@wunner.de>,
"jgg@ziepe.ca" <jgg@ziepe.ca>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] tpm,tpm_tis: Avoid warning splat at shutdown
Date: Thu, 1 Feb 2024 16:40:35 +0000 [thread overview]
Message-ID: <MW5PR84MB184274E28D83DC337B486CEFAB432@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20240201113646.31734-1-l.sanfilippo@kunbus.com>
> From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
> Sent: Thursday, February 1, 2024 5:37 AM
> Subject: [PATCH] tpm,tpm_tis: Avoid warning splat at shutdown
>
> If interrupts are not activated the work struct 'free_irq_work' is not
> initialized. This results in a warning splat at module shutdown.
>
> Fix this by always initializing the work regardless of whether interrupts
> are activated or not.
That's using flush_work(), which just waits for one to complete. Is there
any case where multiple work entries could be queued, and cancel_work_sync()
would be necessary?
tpm_tis_probe_irq() has a loop calling tpm_tis_probe_irq_single()
for 3 to 15. Could each of those could trigger an interrupt storm and
call tpm_tis_revert_interrupts(), which calls schedule_work()?
next prev parent reply other threads:[~2024-02-01 17:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 11:36 Lino Sanfilippo
2024-02-01 16:40 ` Elliott, Robert (Servers) [this message]
2024-02-01 23:18 ` Jarkko Sakkinen
2024-02-02 1:13 ` Lino Sanfilippo
2024-02-01 23:03 ` Jarkko Sakkinen
2024-03-05 15:43 ` Paul Menzel
2024-03-07 20:05 ` Jarkko Sakkinen
2024-03-07 20:33 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW5PR84MB184274E28D83DC337B486CEFAB432@MW5PR84MB1842.NAMPRD84.PROD.OUTLOOK.COM \
--to=elliott@hpe.com \
--cc=LinoSanfilippo@gmx.de \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=p.rosenberger@kunbus.com \
--cc=peterhuewe@gmx.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®