From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.envs.net (mail.envs.net [157.180.15.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5242F2868B4 for ; Sun, 16 Aug 2026 03:10:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=157.180.15.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786849855; cv=none; b=GrziMLA8sKj6VerpI+wNMRgLWq2P6mGZkfZ5hl8myBOIRTgyy0lEoAm3GYJzTPPpXZqxV4wableDRBe9sK1ualIEx1K7/tJHPbZO//Qim1qr5yAjn3gA5lpf82plltEDSqfVm8a59+v8b6SQDSvkdNzI2bSO0TPG2Nkl7oQHvSI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786849855; c=relaxed/simple; bh=THNaG18hCRuMyp28k58DLD3qnHxBLp2XZUx4BLxJCjo=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OLHoTxHZzJaKvQggq0yLpgObYRdeKJr89v4UUemLYY0+z32djWwxkNj4E6163ST99CGdofPkdUVai8FZco9vq7PZZyja/ptvYTGLsT0vcv+Wn9jrhlnJAugKAc/uaYTOZiwoSRcvCy9Mk6KCBT8gzBW40ceTxasv9J46xTTJrd0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=envs.net; spf=pass smtp.mailfrom=envs.net; dkim=pass (4096-bit key) header.d=envs.net header.i=@envs.net header.b=HsTpILb+; arc=none smtp.client-ip=157.180.15.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=envs.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=envs.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=envs.net header.i=@envs.net header.b="HsTpILb+" Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id 660C11C00F1; Sun, 16 Aug 2026 03:10:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1786849850; bh=THNaG18hCRuMyp28k58DLD3qnHxBLp2XZUx4BLxJCjo=; h=From:To:Subject:Date:In-Reply-To:References:From; b=HsTpILb+yo2hHZjrSOp/fRGsrieBCJCeMxu9N56hnAi+om0Bcx5seBcRzs2SxQK3B iGylaWonk3etR/8BZBgTu8Cm5tRtK7YUgMOZ59JwHv9kzSDrumwDHdtd9Qt3RPxtAb uE23uUXsHgJPld2wjV37Nd3kAhZ5E9mHts7r3FjMtVhpJQH3FZ004MjRTWYgr+IskL GorGkPNNYwuj8vd6d6gRVmL5hfuXpkNl+6Jagb/UK8+0x33RJub0qbL62l5k+njn+4 c68s3KRTjHM79t0PdkKxaFr0Mj1UB5gZYAPCNKBGbMRFmfzdFRan26eVz4QYCIBGuO tLY4E+PiCMBjy5de9as6lcQD0ghK1yh4KIB0j99SNpH0O7rIiUgaeZY+QX+4ANV78Z AY2Wm5aQwLY9pwBIeQfGThHSPds2Iq4lysaSFwKKSEDOvPEg3zwkmlJ5RGMLUryDs0 /L2JfChD50mnqC5T9gLOw9YeQG3ZqP9jW9pZ/+LMLsInAnkC8+Kkve9zCFXN3zNbcd 8SzhUUJAO3fTWjwQ2Vhi2Pzv3yvby13D3lFHC7A/YzNkibD1VUhp/cVaouP7cWh8CZ 9AVmqCEVtYZtAJt89e0w1eAJNjR/2wQ9g1Q2A/RVxfNu4EkuuAGkYASdNagqVNbTNY iZM6rg88hz5HKRiDO9IBP1lc= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 8thAD0Q16lNr; Sun, 16 Aug 2026 03:10:44 +0000 (UTC) Received: from xtex-l16.localnet (unknown [120.230.214.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sun, 16 Aug 2026 03:10:44 +0000 (UTC) From: xtex To: Bingwu Zhang , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Chunhai Guo , linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org, Bingwu Zhang Subject: Re: [PATCH] erofs: remove erofs_dev_context->rwsem Date: Sun, 16 Aug 2026 11:11:28 +0800 Message-ID: Organization: AstraFall In-Reply-To: References: <20260816-erofs-remove-rwsem-v1-1-78b60b855fa6@astrafall.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi, On Sunday, August 16, 2026 11:06:05=E2=80=AFAM China Standard Time Gao Xian= g wrote: > Hi Bingwu, >=20 > On Sun, Aug 16, 2026 at 10:00:12AM +0800, Bingwu Zhang wrote: > > From: Bingwu Zhang > >=20 > > devs->tree is only modified in initialization and > > destruction code paths and will never be concurrent > > with data reading. Thus there is no need to guard > > idr_alloc/idr_find with a rwsem. >=20 > Thanks for the patch. >=20 > In principle, yes, but it's also no problem to leave it as-is in case > some use cases later need adjust the device_info of a dev for example > at runtime. >=20 > Or if it causes any noticeable performance penalty, that will be one > reason to drop it now. Thanks for the reply. I don't think it caused any notice performance=20 difference so it looks good to me to keep the rwsem. Thanks, Bingwu Zhang >=20 > Thanks, > Gao Xiang >=20 > > Signed-off-by: Bingwu Zhang