From: James Morris <jmorris@intercode.com.au>
To: Maciej Soltysiak <solt@dns.toxicfilms.tv>
Cc: linux-kernel@vger.kernel.org, "David S. Miller" <davem@redhat.com>
Subject: Re: [PATCH] make icmp.c be more verbose on broadcast icmp errors
Date: Mon, 26 May 2003 16:12:34 +1000 (EST) [thread overview]
Message-ID: <Mutt.LNX.4.44.0305261611180.7870-100000@excalibur.intercode.com.au> (raw)
In-Reply-To: <Pine.LNX.4.51.0305231222450.8169@dns.toxicfilms.tv>
On Fri, 23 May 2003, Maciej Soltysiak wrote:
> if (net_ratelimit())
> printk(KERN_WARNING "%u.%u.%u.%u sent an invalid ICMP "
> + "type %u, code %u "
> "error to a broadcast.\n",
> - NIPQUAD(skb->nh.iph->saddr));
> + NIPQUAD(skb->nh.iph->saddr),
> + icmph->type, icmph->code);
> if (net_ratelimit())
> - printk(KERN_WARNING "%u.%u.%u.%u sent an invalid ICMP error to a broadcast.\n",
> - NIPQUAD(skb->nh.iph->saddr));
> + printk(KERN_WARNING "%u.%u.%u.%u sent an invalid ICMP type %u, code %u error to a broadcast.\n",
> + NIPQUAD(skb->nh.iph->saddr),
> + icmph->type, icmph->code);
Perhaps make this a static inline, icmp_warn_invalid() or similar.
- James
--
James Morris
<jmorris@intercode.com.au>
prev parent reply other threads:[~2003-05-26 5:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-23 10:55 Maciej Soltysiak
2003-05-26 4:14 ` David S. Miller
2003-05-26 5:56 ` Christoph Hellwig
2003-05-26 5:59 ` David S. Miller
2003-05-26 6:12 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Mutt.LNX.4.44.0305261611180.7870-100000@excalibur.intercode.com.au \
--to=jmorris@intercode.com.au \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=solt@dns.toxicfilms.tv \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®