mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Morris <jmorris@intercode.com.au>
To: Patrick Mansfield <patmans@us.ibm.com>
Cc: Andrew Morton <akpm@digeo.com>,
	Stephen Hemminger <shemminger@osdl.org>,
	Jeff Garzik <jgarzik@pobox.com>,
	"David S. Miller" <davem@redhat.com>, <netdev@oss.sgi.com>,
	<linux-kernel@vger.kernel.org>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: 2.5.70-bk+ broken networking
Date: Thu, 5 Jun 2003 13:25:58 +1000 (EST)	[thread overview]
Message-ID: <Mutt.LNX.4.44.0306051325110.335-100000@excalibur.intercode.com.au> (raw)
In-Reply-To: <20030604184341.A10256@beaverton.ibm.com>

On Wed, 4 Jun 2003, Patrick Mansfield wrote:

> [root@elm3b79 root]# ifup eth0
> sender address length == 0

This is a bug introduced by a coding style cleanup, fix below.


- James
-- 
James Morris
<jmorris@intercode.com.au>

--- bk.pending/net/core/iovec.c	2003-06-05 11:12:59.000000000 +1000
+++ bk.w1/net/core/iovec.c	2003-06-05 13:30:06.000000000 +1000
@@ -47,10 +47,10 @@ int verify_iovec(struct msghdr *m, struc
 						  address);
 			if (err < 0)
 				return err;
-			m->msg_name = address;
-		} else
-			m->msg_name = NULL;
-	}
+		}
+		m->msg_name = address;
+	} else
+		m->msg_name = NULL;
 
 	size = m->msg_iovlen * sizeof(struct iovec);
 	if (copy_from_user(iov, m->msg_iov, size))


  reply	other threads:[~2003-06-05  3:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-04 23:14 Stephen Hemminger
2003-06-04 23:25 ` Stephen Hemminger
2003-06-04 23:25 ` Andrew Morton
2003-06-05  1:43   ` Patrick Mansfield
2003-06-05  3:25     ` James Morris [this message]
2003-06-05  3:32       ` Arnaldo Carvalho de Melo
2003-06-05  5:03         ` David S. Miller
2003-06-05 16:55       ` Stephen Hemminger
2003-06-05  1:56   ` Andrew Morton
2003-06-05  2:33     ` Arnaldo Carvalho de Melo
2003-06-05  2:42       ` Arnaldo Carvalho de Melo
2003-06-05  3:26       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Mutt.LNX.4.44.0306051325110.335-100000@excalibur.intercode.com.au \
    --to=jmorris@intercode.com.au \
    --cc=akpm@digeo.com \
    --cc=davem@redhat.com \
    --cc=hch@infradead.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    --cc=patmans@us.ibm.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®