>From linux-kernel-owner@vger.kernel.org Thu, 08 Nov 2001 19:50:05 -0800 Received: from [199.183.24.194] by hotmail.com (3.2) with ESMTP id MHotMailBDB49D320016400431C9C7B718C2E1070; Thu, 08 Nov 2001 19:49:11 -0800 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 8 Nov 2001 22:45:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 8 Nov 2001 22:45:27 -0500 Received: from cc361913-a.flrtn1.occa.home.com ([24.0.193.171]:56198 "EHLO mirai.cx") by vger.kernel.org with ESMTP id ; Thu, 8 Nov 2001 22:45:16 -0500 Received: from pobox.com (localhost.localdomain [127.0.0.1]) by mirai.cx (8.11.6/8.11.6) with ESMTP id fA93jDN07748; Thu, 8 Nov 2001 19:45:13 -0800 Message-ID: <3BEB5149.B0B7990F@pobox.com> Date: Thu, 08 Nov 2001 19:45:13 -0800 From: J Sloan Organization: J S Concepts X-Mailer: Mozilla 4.78 [en] (X11; U; Linux 2.4.14 i686) X-Accept-Language: en MIME-Version: 1.0 To: Linux Kernel Developer CC: linux-kernel@vger.kernel.org Subject: Re: CPQARRAY driver horribly broken in 2.4.14 In-Reply-To: Content-Type: multipart/mixed; boundary="------------0B4AB4FD009D357EEBF46038" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org This is a multi-part message in MIME format. --------------0B4AB4FD009D357EEBF46038 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Linux Kernel Developer wrote: > Hi all, > > I'm using the cpqarray driver for a Compaq Smart Arrat 3100ES > controller on a Compaq Proliant 7000. Today I tried upgrading the kernel to > 2.4.14. Soon after the upgrade I though about making a small change in the > kernel however as soon as I tried doing a "make dep" the system oopsed and > froze. Been there, done that, bought the t-shirt. The attached patch courtesy of Jens Axboe fixed my Compaq 6500 which was giving me fits - basically in 2.4.14 it had a nasty habit of scribbling on the disk and then locking up, requiring a power cycle, manual fsck and file restoration to get it running again. With this patch 2.4.14 has been solid. cu jjs --------------0B4AB4FD009D357EEBF46038 Content-Type: text/plain; charset=us-ascii; name="cciss-dequeue-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="cciss-dequeue-1" --- linux/drivers/block/cciss.c~ Thu Nov 8 11:36:24 2001 +++ linux/drivers/block/cciss.c Thu Nov 8 11:37:03 2001 @@ -1307,6 +1307,8 @@ if (( c = cmd_alloc(h, 1)) == NULL) goto startio; + blkdev_dequeue_request(creq); + spin_unlock_irq(&io_request_lock); c->cmd_type = CMD_RWREQ; @@ -1386,12 +1388,6 @@ spin_lock_irq(&io_request_lock); - blkdev_dequeue_request(creq); - - /* - * ehh, we can't really end the request here since it's not - * even started yet. for now it shouldn't hurt though - */ addQ(&(h->reqQ),c); h->Qdepth++; if(h->Qdepth > h->maxQsinceinit) --------------0B4AB4FD009D357EEBF46038-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/