From: "Shirley Ma" <xma@us.ibm.com>
To: Andi Kleen <ak@muc.de>
Cc: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org
Subject: Re: IPv6 PMTU/MTU related patch for 2.5.31 kernel
Date: Wed, 28 Aug 2002 14:01:03 -0700 [thread overview]
Message-ID: <OF8DA779DB.E7BE1739-ON88256C23.0072CBDB@boulder.ibm.com> (raw)
Andi,
I think it needs to be RFC conformance for PMTU to avoid unnecessary
probing PMTU network traffics. For UDP and ICMP which doesn't have any
reference on this kind of route, the route needs to be around for a while
instead of being delete within a very short time even immediately.
Thanks
Shirley Ma
Andi Kleen <ak@muc.de>@averell.firstfloor.org on 08/28/2002 02:44:34 AM
Sent by: andi@averell.firstfloor.org
To: Shirley Ma/Beaverton/IBM@IBMUS
cc: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org, LTC IPv6
Subject: Re: IPv6 PMTU/MTU related patch for 2.5.31 kernel
"Shirley Ma" <xma@us.ibm.com> writes:
> + /* If there is no reference to this route, this route will be
> + deleted by fib6_run_gc() within 30 secs. The cached
decreased
> + PMTU will be gone. It's possible to be deleted before any
> + other protocol using it. Then the old larger pmtu will be
used,
> + which against RFC1981: detect an increase MUST NOT be done
> + less than 5 minutes after a Packet Too Big Messages has
> + been received for the given path.
> + */
> + dst_hold(&nrt->u.dst);
This seems overkill and could potentially tie up quite a of dst
entries for dubious purposes. This RFC requirement clearly cannot be
followed in all cases, e.g. when you run out of memory for the
destination cache. This is one such case too.
I think only following it when there is still another reference to the
dst entry (e.g. from a socket) is reasonably near the spirit of the
specification.
-Andi
next reply other threads:[~2002-08-28 20:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-28 21:01 Shirley Ma [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-08-28 0:56 Shirley Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF8DA779DB.E7BE1739-ON88256C23.0072CBDB@boulder.ibm.com \
--to=xma@us.ibm.com \
--cc=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®