From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 26 Sep 2001 19:28:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 26 Sep 2001 19:28:36 -0400 Received: from d12lmsgate.de.ibm.com ([195.212.91.199]:61658 "EHLO d12lmsgate.de.ibm.com") by vger.kernel.org with ESMTP id ; Wed, 26 Sep 2001 19:28:25 -0400 Importance: Normal Subject: Bug in tcp_v4_hnd_req? To: davem@redhat.com Cc: linux-kernel@vger.kernel.org, "Martin Schwidefsky" , "Utz Bacher" X-Mailer: Lotus Notes Release 5.0.3 (Intl) 21 March 2000 Message-ID: From: "Ulrich Weigand" Date: Thu, 27 Sep 2001 01:27:33 +0200 X-MIMETrack: Serialize by Router on D12ML028/12/M/IBM(Release 5.0.8 |June 18, 2001) at 27/09/2001 01:28:45 MIME-Version: 1.0 Content-type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Hello, the following code in tcp_v4_hnd_req looks broken: if (nsk) { if (nsk->state != TCP_TIME_WAIT) { bh_lock_sock(nsk); return nsk; } tcp_tw_put((struct tcp_tw_bucket*)sk); return NULL; } Shouldn't it put *nsk* instead of sk? This appears to be the cause of weird crashes under heavy network load we've been experiencing ... Mit freundlichen Gruessen / Best Regards Ulrich Weigand -- Dr. Ulrich Weigand Linux for S/390 Design & Development IBM Deutschland Entwicklung GmbH, Schoenaicher Str. 220, 71032 Boeblingen Phone: +49-7031/16-3727 --- Email: Ulrich.Weigand@de.ibm.com