From: "Mark Peloquin" <peloquin@us.ibm.com>
To: "Kevin M Corry" <corryk@us.ibm.com>
Cc: Robert Varga <nite@hq.alert.sk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EVMS core 2/4: evms.h
Date: Fri, 4 Oct 2002 09:56:11 -0500 [thread overview]
Message-ID: <OFA9EC13A7.01869764-ON85256C48.00510A87@pok.ibm.com> (raw)
On 10/04/2002 at 9:03 AM, Kevin Corry wrote:
> > <snip...>
> >
> > > Possibly shortened to:
> > >
> > > static inline int list_member(struct list_head *member)
> > > {
> > > return member->next && member->prev;
> > > }
> > >
> > > Faster, and (at least to me) it looks more obvious.
> >
> > Yes, this may be shorter. However with this change
> > the return type would also need to be changed to
> > portable across archs.
> What would the return type have to be?
Ok, I was (incorrectly) thinking this would return
a *list_head, but after waking up a bit more I see
the "&&" which should return a int.
So I agree Robert's improvement is fine!
Mark
next reply other threads:[~2002-10-04 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-04 14:56 Mark Peloquin [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-10-04 13:59 [Evms-devel] " Mark Peloquin
2002-10-04 14:03 ` Kevin Corry
2002-10-04 14:43 ` Kevin Corry
2002-10-03 12:36 Kevin Corry
2002-10-03 14:50 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OFA9EC13A7.01869764-ON85256C48.00510A87@pok.ibm.com \
--to=peloquin@us.ibm.com \
--cc=corryk@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nite@hq.alert.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®