Re: [PATCH] 2.5.40 s390.

["Martin Schwidefsky" <schwidefsky@de.ibm.com>]

Hi Al,

> * please switch to use of alloc_disk()/put_disk()
> * don't bother with disk->part allocation - it's done by add_disk()
> * ditto for freeing it (del_gendisk())
> * dasd_partition_to_kdev_t() - please use ->gdp->{major,first_minor}
> * s/bdevname(d_device->bdev)/d_device->gdp->disk_name/
> * lose ->bdev
 I'll do that.

> Note that we are getting bdev->bd_disk and disk->private pretty soon, so
> we'll have very easy way to do your devmap by bdev stuff.
Thats good to hear. One of the reasons for me to split of dasd_devmap.c
was to have the code concerned about minors and friends in on place.
That makes it easy to get rid of it.

> Anther thing: tapeblock.c and friends.
> <rant>
 > In ~ 2.5.16 blksize_size[] had been removed.  Tape-related code
> in s390 was using it, but that was fairly easy to get rid of.  Now, in
> 2.5.21 somebody (presumably architecture maintainers) had submitted a
> patch that
 > * reverted all compile fixes, etc. that had happened in 2.5
 > * reintroduced use of (long-dead) blksize_size[]
> ^#$^%@!
> Folks, if you do something like that, at least check the bloody changelog...
> </rant>

Oh, that must have been me then. Sorry about that. But there is a reason
for my obvious desinterest in the tape device driver. I'm just rewriting
it completely. So don't bother with the old one.

blue skies,
   Martin

Linux/390 Design & Development, IBM Deutschland Entwicklung GmbH
Schönaicherstr. 220, D-71032 Böblingen, Telefon: 49 - (0)7031 - 16-2247
E-Mail: schwidefsky@de.ibm.com