From: Janice Girouard <girouard@us.ibm.com>
To: "David S. Miller" <davem@redhat.com>
Cc: Daniel Stekloff <stekloff@us.ibm.com>,
janiceg@us.ibm.com, jgarzik@pobox.com, kenistonj@us.ibm.com,
Larry Kessler <lkessler@us.ibm.com>,
linux-kernel@vger.kernel.org, netdev@oss.sgi.com, niv@us.ibm.com,
<niv@us.ibm.com>
Subject: Re: patch for common networking error messages
Date: Mon, 16 Jun 2003 17:29:15 -0500 [thread overview]
Message-ID: <OFF1F6B3DC.30C0E5DE-ON85256D47.007AEFAF@us.ibm.com> (raw)
From: "David S. Miller" <davem@redhat.com>
Date : 06/16/2003 05:13 PM
egrep "promiscuous mode" net/core/dev.c | grep printk
I noticed when I performed the grep, the printk shows:
printk(KERN_INFO "device %s %s promiscuous mode\n"
For the sake of consistency and automatic error log analysis, it might be
nice to standardize on a message closer to:
printk(KERN_INFO "%s: %s promiscuous mode\n"
It's somewhat common, but not universal to start the error message with the
device name followed by a colon.
Janice
next reply other threads:[~2003-06-16 22:15 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-16 22:29 Janice Girouard [this message]
2003-06-16 22:27 ` David S. Miller
2003-06-16 22:45 ` Nivedita Singhvi
2003-06-16 22:52 ` David S. Miller
2003-06-17 0:07 ` Nivedita Singhvi
-- strict thread matches above, loose matches on Subject: below --
2003-06-17 20:57 Janice Girouard
2003-06-17 21:14 ` David S. Miller
2003-06-17 20:40 Janice Girouard
2003-06-17 20:42 ` David S. Miller
2003-06-17 2:12 Janice Girouard
2003-06-17 4:34 ` Valdis.Kletnieks
2003-06-17 16:08 ` Stephen Hemminger
2003-06-17 16:09 ` David S. Miller
2003-06-17 18:46 ` Jeff Garzik
2003-06-17 19:06 ` Janice M Girouard
2003-06-17 19:23 ` Jeff Garzik
2003-06-17 19:46 ` Janice M Girouard
2003-06-17 19:50 ` David S. Miller
2003-06-17 20:24 ` Janice M Girouard
2003-06-17 20:27 ` David S. Miller
2003-06-17 0:44 Janice Girouard
2003-06-17 1:19 ` David S. Miller
2003-06-17 14:34 ` Mr. James W. Laferriere
2003-06-16 22:50 Janice Girouard
2003-06-16 22:55 ` David S. Miller
2003-06-21 12:36 ` Alan Cox
2003-06-21 14:27 ` Jamal Hadi
2003-06-23 0:46 ` David S. Miller
2003-06-23 11:54 ` Alan Cox
2003-06-16 20:30 Janice M Girouard
2003-06-16 20:38 ` David S. Miller
2003-06-16 20:53 ` Andi Kleen
2003-06-16 20:51 ` David S. Miller
2003-06-16 22:27 ` Andrew Morton
2003-06-17 7:09 ` Andi Kleen
2003-06-17 7:20 ` Andrew Morton
2003-06-16 20:59 ` Janice M Girouard
2003-06-16 22:48 ` Jeff Garzik
2003-06-16 22:52 ` Jeff Garzik
2003-06-16 22:13 ` Nivedita Singhvi
2003-06-16 22:13 ` David S. Miller
2003-06-16 22:50 ` Nivedita Singhvi
2003-06-16 22:57 ` David S. Miller
2003-06-16 23:02 ` Donald Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OFF1F6B3DC.30C0E5DE-ON85256D47.007AEFAF@us.ibm.com \
--to=girouard@us.ibm.com \
--cc=davem@redhat.com \
--cc=janiceg@us.ibm.com \
--cc=jgarzik@pobox.com \
--cc=kenistonj@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkessler@us.ibm.com \
--cc=netdev@oss.sgi.com \
--cc=niv@us.ibm.com \
--cc=stekloff@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®