From: Biju Das <biju.das.jz@bp.renesas.com>
To: "m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
"bsegall@google.com" <bsegall@google.com>,
"peterz@infradead.org" <peterz@infradead.org>
Cc: "bristot@redhat.com" <bristot@redhat.com>,
"bsegall@google.com" <bsegall@google.com>,
"chris.hyser@oracle.com" <chris.hyser@oracle.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"dietmar.eggemann@arm.com" <dietmar.eggemann@arm.com>,
"efault@gmx.de" <efault@gmx.de>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"joel@joelfernandes.org" <joel@joelfernandes.org>,
"joshdon@google.com" <joshdon@google.com>,
"juri.lelli@redhat.com" <juri.lelli@redhat.com>,
"kprateek.nayak@amd.com" <kprateek.nayak@amd.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mingo@kernel.org" <mingo@kernel.org>,
"patrick.bellasi@matbug.net" <patrick.bellasi@matbug.net>,
Pavel Machek <pavel@ucw.cz>,
"peterz@infradead.org" <peterz@infradead.org>,
"pjt@google.com" <pjt@google.com>,
"qperret@google.com" <qperret@google.com>,
"qyousef@layalina.io" <qyousef@layalina.io>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"tim.c.chen@linux.intel.com" <tim.c.chen@linux.intel.com>,
"timj@gnu.org" <timj@gnu.org>,
"vincent.guittot@linaro.org" <vincent.guittot@linaro.org>,
"youssefesmat@chromium.org" <youssefesmat@chromium.org>,
"yu.c.chen@intel.com" <yu.c.chen@intel.com>,
"mgorman@suse.de" <mgorman@suse.de>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH] sched/fair: fix pick_eevdf to always find the correct se
Date: Thu, 5 Oct 2023 07:31:34 +0000 [thread overview]
Message-ID: <OS0PR01MB59220AF3959BDC5FEFC0340F86CAA@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
Subject: Re: [PATCH] sched/fair: fix pick_eevdf to always find the correct se
Date: Wed, 4 Oct 2023 22:39:39 +0200 [thread overview]
Message-ID: <c92bc8a6-225d-4fd2-88b5-8994090fb2de@samsung.com> (raw)
In-Reply-To: <xm261qego72d.fsf_-_@google.com>
Hi,
On 30.09.2023 02:09, Benjamin Segall wrote:
> The old pick_eevdf could fail to find the actual earliest eligible
> deadline when it descended to the right looking for min_deadline, but it
> turned out that that min_deadline wasn't actually eligible. In that case
> we need to go back and search through any left branches we skipped
> looking for the actual best _eligible_ min_deadline.
>
> This is more expensive, but still O(log n), and at worst should only
> involve descending two branches of the rbtree.
>
> I've run this through a userspace stress test (thank you
> tools/lib/rbtree.c), so hopefully this implementation doesn't miss any
> corner cases.
>
> Fixes: 147f3efaa241 ("sched/fair: Implement an EEVDF-like scheduling policy")
> Signed-off-by: Ben Segall <bsegall@google.com>
This patch causing issues [1] in Renesas RZ/G2L SMARC EVK platform. Reverting the patch fixes the warning messages
[1]
[ 25.550898] EEVDF scheduling fail, picking leftmost
[ 15.109634] ======================================================
[ 15.109636] WARNING: possible circular locking dependency detected
[ 15.109641] 6.6.0-rc4-next-20231005-arm64-renesas-ga03f9ebbbb4c #1165 Not tainted
[ 15.109648] ------------------------------------------------------
[ 15.109649] migration/0/16 is trying to acquire lock:
[ 15.109654] ffff800081713460 (console_owner){..-.}-{0:0}, at: console_flush_all.constprop.0+0x1a0/0x438
[ 15.109694]
[ 15.109694] but task is already holding lock:
[ 15.109697] ffff00007fbd2298 (&rq->__lock){-.-.}-{2:2}, at: __schedule+0xd0/0xbe0
[ 15.109718]
[ 15.109718] which lock already depends on the new lock.
[ 15.109718]
[ 15.109720]
[ 15.109720] the existing dependency chain (in reverse order) is:
25.551560] __down_trylock_console_sem+0x34/0xb8
[ 25.551567] console_trylock+0x24/0x74
[ 25.551574] vprintk_emit+0x114/0x388
[ 25.551581] vprintk_default+0x34/0x3c
[ 25.551588] vprintk+0x9c/0xb4
[ 25.551594] _printk+0x58/0x7c
[ 25.551600] pick_next_task_fair+0x274/0x480
[ 25.551608] __schedule+0x154/0xbe0
[ 25.551616] schedule+0x48/0x110
[ 25.551623] worker_thread+0x1b8/0x3f8
[ 25.551630] kthread+0x114/0x118
[ 25.551635] ret_from_fork+0x10/0x20
[ OK ] Started System Logging Service.
[ 26.099203] EEVDF scheduling fail, picking leftmost
Cheers,
Biju
next reply other threads:[~2023-10-05 16:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 7:31 Biju Das [this message]
2023-10-05 7:58 ` Biju Das
2023-10-05 15:02 ` Peter Zijlstra
2023-10-05 15:08 ` Biju Das
2023-10-06 8:36 ` Marek Szyprowski
2023-10-06 9:38 ` Biju Das
[not found] ` <553e2ee4-ab3a-4635-a74f-0ba4cc03f3f9@samsung.com>
2023-10-06 10:31 ` Mike Galbraith
2023-10-06 14:00 ` Peter Zijlstra
2023-10-06 14:39 ` Mike Galbraith
2023-10-06 15:55 ` Peter Zijlstra
2023-10-06 16:54 ` Mike Galbraith
2023-10-06 19:24 ` Peter Zijlstra
2023-10-06 20:15 ` Marek Szyprowski
2023-10-06 23:27 ` Mike Galbraith
2023-10-07 0:37 ` Chen Yu
2023-10-07 6:26 ` Biju Das
2023-10-07 6:42 ` Chen Yu
2023-10-09 14:27 ` Phil Auld
2023-10-10 2:08 ` Chen Yu
2023-10-07 6:24 ` Biju Das
2023-10-09 7:53 ` [tip: sched/urgent] sched/eevdf: Fix min_deadline heap integrity tip-bot2 for Peter Zijlstra
2023-10-05 15:11 ` [PATCH] sched/fair: fix pick_eevdf to always find the correct se Peter Zijlstra
-- strict thread matches above, loose matches on Subject: below --
2023-05-31 11:58 [PATCH 00/15] sched: EEVDF and latency-nice and/or slice-attr Peter Zijlstra
2023-05-31 11:58 ` [PATCH 05/15] sched/fair: Implement an EEVDF like policy Peter Zijlstra
2023-09-30 0:09 ` [PATCH] sched/fair: fix pick_eevdf to always find the correct se Benjamin Segall
[not found] ` <CGME20231004203940eucas1p2f73b017497d1f4239a6e236fdb6019e2@eucas1p2.samsung.com>
2023-10-04 20:39 ` Marek Szyprowski
2023-10-11 12:12 ` Abel Wu
2023-10-11 13:14 ` Peter Zijlstra
2023-10-11 21:01 ` Benjamin Segall
2023-10-12 10:25 ` Abel Wu
2023-10-12 17:51 ` Benjamin Segall
2023-10-13 3:46 ` Abel Wu
2023-10-13 16:51 ` Benjamin Segall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB59220AF3959BDC5FEFC0340F86CAA@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=chris.hyser@oracle.com \
--cc=corbet@lwn.net \
--cc=dietmar.eggemann@arm.com \
--cc=efault@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=patrick.bellasi@matbug.net \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=qperret@google.com \
--cc=qyousef@layalina.io \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=timj@gnu.org \
--cc=vincent.guittot@linaro.org \
--cc=youssefesmat@chromium.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®