From: Biju Das <biju.das.jz@bp.renesas.com>
To: Marc Zyngier <maz@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Zheng Wang <zyytlz.wz@163.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: RE: [PATCH] usb: gadget: udc: renesas_usb3: Fix RZ/V2M {modprobe,bind} error
Date: Tue, 30 May 2023 12:37:30 +0000 [thread overview]
Message-ID: <OS0PR01MB59227AF1F83A73620179CDF8864B9@OS0PR01MB5922.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <86a5xncxhc.wl-maz@kernel.org>
Hi Laurent and Marc,
Thanks for your feedback.
> Subject: Re: [PATCH] usb: gadget: udc: renesas_usb3: Fix RZ/V2M
> {modprobe,bind} error
>
> On Mon, 29 May 2023 09:56:56 +0100,
> Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote:
> >
> > The name is just informative so I suppose it's ok. It makes me wonder,
> > though, if the usb3drd driver shouldn't register the interrupt handler
> > itself.
>
> Well, it registers it itself, but pretending to be another device.
> Which is wrong on many levels.
OK, Will register the handler in usb3drd driver and expose register/unregister handler API
with cb function to avoid duplication of the code with renesas_usb3 driver.
Basically, there will be 2 exported functions + 1 spinlock introduced in usb3drd driver
USB3DRD driver register the IRQ handler
Probe/remove from renesas_usb3 driver register/unregister the cb function. Whenever there is drd irq
cb function will be called.
I will send next version with these changes.
Cheers,
Biju
next prev parent reply other threads:[~2023-05-30 12:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230526143615.372338-1-biju.das.jz@bp.renesas.com>
[not found] ` <20230529061714.GA25984@pendragon.ideasonboard.com>
2023-05-29 8:42 ` Biju Das
2023-05-29 8:56 ` Laurent Pinchart
2023-05-29 9:12 ` Marc Zyngier
2023-05-30 12:37 ` Biju Das [this message]
2023-05-30 13:16 ` Geert Uytterhoeven
2023-05-30 13:47 ` Biju Das
2023-05-29 9:09 ` Marc Zyngier
2023-05-29 9:39 ` Biju Das
2023-05-29 9:46 ` Laurent Pinchart
2023-05-29 9:59 ` Biju Das
2023-05-29 9:56 ` Marc Zyngier
2023-05-29 10:03 ` Biju Das
2023-05-29 11:15 ` Marc Zyngier
2023-05-29 13:20 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS0PR01MB59227AF1F83A73620179CDF8864B9@OS0PR01MB5922.jpnprd01.prod.outlook.com \
--to=biju.das.jz@bp.renesas.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maz@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
--cc=zyytlz.wz@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®