RE: [PATCH] i2c: designware: Add ACPI HID for DWAPB I2C controller on Fujitsu MONAKA

["Yoshihiro Furudera (Fujitsu)" <fj5100bi@fujitsu.com>]

Hi, Andy Shevchenko
Thanks for you review/comments.

> On Mon, Oct 21, 2024 at 07:22:55AM +0000, Yoshihiro Furudera (Fujitsu) wrote:
> > > On Fri, Oct 18, 2024 at 01:58:26AM +0000, Yoshihiro Furudera wrote:
> 
> ...
> 
> > > Also please give more details:
> > > 1) is this ID already present in the wild
> > >    (in the products that one may just go and buy)?
> > > if so, mention the example of the product.
> >
> > Not available at this time.
> > It is planned to be implemented in the MONAKA server scheduled for
> > shipment in 2027.
> 
> So, summarize that in a short sentence, like "This will be used in the MONAKA
> server scheduled for shipment in 2027."

Understood.
I will be more careful in the future.

> 
> > > 2) provide an excerpt from DSDT for the Device object that uses this _HID.
> >
> > The DSDT information obtained when verified using an in-house
> > simulator is presented below.
> 
> Just strip it to the only significant parts, see below
> 
>      Device (SMB0)
>      {
>          Name (_HID, "FUJI200B")  // _HID: Hardware ID
>          Name (_UID, Zero)  // _UID: Unique ID
>          ...
>          Name (_CRS, ResourceTemplate ()
>          {
>              Memory32Fixed (ReadWrite,
>                  0x2A4B0000,         // Address Base
>                  0x00010000,         // Address Length
>                  )
>              Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive, ,, )
>              {
>                  0x00000159,
>              }
>          })
>          ...
>      }

Understood.

> 
> ...
> 
> Hmm... Why Device object is called SMB0, are you sure it's the correct one?

We considered the string to be the most concise
representation of SMBus HC#0, given the general
constraint that object names should ideally be
four characters or less. We understood that,
unlike HID, SMBus object names are vendor-specific.

> 
> --
> With Best Regards,
> Andy Shevchenko
> 

Best Regards,
Yoshihiro Furudera