mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ryan Chen <ryan_chen@aspeedtech.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@codeconstruct.com.au>,
	Kevin Chen <kevin_chen@aspeedtech.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>
Subject: RE: [PATCH v2] dt-bindings: interrupt-controller: aspeed: Add parent node compatibles and refine documentation
Date: Thu, 17 Jul 2025 02:25:38 +0000	[thread overview]
Message-ID: <OS8PR06MB75414FD894E30FAE2D29DD5FF251A@OS8PR06MB7541.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <20250716-spotted-spirited-axolotl-c94e0b@krzk-bin>

> Subject: Re: [PATCH v2] dt-bindings: interrupt-controller: aspeed: Add parent
> node compatibles and refine documentation
> 
> On Tue, Jul 15, 2025 at 10:42:58AM +0800, Ryan Chen wrote:
> > - Add 'aspeed,ast2700-intc0' and 'aspeed,ast2700-intc1' compatible
> > strings for parent interrupt controller nodes, in addition to the
> > existing 'aspeed,ast2700-intc-ic' for child nodes.
> > - Clarify the relationship and function of INTC0, INTC1, and the GIC.
> > - Update and clarify documentation, block diagram, and examples to
> > reflect the hierarchy and compatible usage.
> > - Documentation and example refine.
> 
> So 7 lines describing obvious - what you did and three lines below describing
> non-obvious, why you did it. It should be reversed.

Thanks your feedback.

How about following description?

The AST2700 SoC contains two independent top-level interrupt controllers (INTC0 and INTC1),
each responsible for handling different peripheral groups and occupying separate register spaces.
Above them, a GIC controller acts as the global interrupt aggregator. 
Accurately describing this hierarchical hardware structure in the device tree requires distinct compatible strings for the parent nodes of INTC0 and INTC1.

- Adds 'aspeed,ast2700-intc0' and 'aspeed,ast2700-intc1' compatible strings for parent interrupt controller nodes (in addition to the existing 'aspeed,ast2700-intc-ic' for child nodes)
- Clarifies the relationship and function of INTC0 parent (intc0_0~x: child), INTC1 parent (intc1_0~x: child), and the GIC in the documentation
- Updates block diagrams and device tree examples to illustrate the hierarchy and compatible usage
- Refines documentation and example formatting

> 
> >
> > This change allows the device tree and driver to distinguish between
> 
> Why driver needs would matter here?
> 
> > parent (top-level) and child (group) interrupt controller nodes,
> > enabling more precise driver matching SOC register space allocation.
> 
> This just does not make sense. You do not change "precise driver matching" via
> bindings. You fix driver. Especially that there is no driver patch here at all and
> aspeed,ast2700-intc0 are totally unused!
> Don't add ABI which has no users.
> 
> Again, you need to start describing the hardware and the REASONS BEHIND
> from the hardware point of view. Not drivers.
> 
> This change alone based on above explanation makes no sense at all.

Next version, I will move the addition of aspeed,ast2700-intc0 and aspeed,ast2700-intc1 compatible strings into the driver patch,
so they are added together with actual driver support.

Thank you for your guidance.
> 
> Best regards,
> Krzysztof


      reply	other threads:[~2025-07-17  2:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-15  2:42 Ryan Chen
2025-07-16  8:21 ` Krzysztof Kozlowski
2025-07-17  2:25   ` Ryan Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OS8PR06MB75414FD894E30FAE2D29DD5FF251A@OS8PR06MB7541.apcprd06.prod.outlook.com \
    --to=ryan_chen@aspeedtech.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=kevin_chen@aspeedtech.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®