From: Ryan Chen <ryan_chen@aspeedtech.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Eddie James <eajames@linux.ibm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Lee Jones <lee@kernel.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v2 4/4] irqchip/aspeed-scu-ic: Add support AST2700 SCU interrupt controllers
Date: Fri, 5 Sep 2025 08:57:08 +0000 [thread overview]
Message-ID: <OS8PR06MB75416851138FFF2A62AFEE56F203A@OS8PR06MB7541.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <87tt1hwdb1.ffs@tglx>
> Subject: RE: [PATCH v2 4/4] irqchip/aspeed-scu-ic: Add support AST2700 SCU
> interrupt controllers
>
> On Fri, Sep 05 2025 at 05:55, Ryan Chen wrote:
> >> So you have two different handlers. Why can't you provide two
> >> different mask/unmask/ functions along with a seperate irq chip
> >> instead of cluttering the code with conditionals. Thes two variants share no
> code at all.
> >
> > I will add irq_chip in SCU_VARIANT, like following.
> >
> > struct aspeed_scu_ic_variant {
> > ..
> > + struct irq_chip *irq_chip;
> > };
> >
> > #define SCU_VARIANT(_compat, _shift, _enable, _num, +_irq_chip,
> > _split, _ier, _isr) { \
> > + .irq_chip = _irq_chip, \
> > .....
> > }
> >
> > static const struct aspeed_scu_ic_variant scu_ic_variants[] __initconst = {
> > SCU_VARIANT("aspeed,ast2400-scu-ic", 0, GENMASK(15, 0), 7,
> &aspeed_scu_ic_chip_combined, false, 0, 0),
> > SCU_VARIANT("aspeed,ast2500-scu-ic", 0, GENMASK(15, 0), 7,
> &aspeed_scu_ic_chip_combined, false, 0, 0),
> > SCU_VARIANT("aspeed,ast2600-scu-ic0", 0, GENMASK(5, 0), 6,
> &aspeed_scu_ic_chip_combined, false, 0, 0),
> > SCU_VARIANT("aspeed,ast2600-scu-ic1", 4, GENMASK(5, 4), 2,
> &aspeed_scu_ic_chip_combined, false, 0, 0),
> > SCU_VARIANT("aspeed,ast2700-scu-ic0", 0, GENMASK(3, 0), 4,
> &aspeed_scu_ic_chip_split, true, 0x00, 0x04),
> > SCU_VARIANT("aspeed,ast2700-scu-ic1", 0, GENMASK(3, 0), 4,
> &aspeed_scu_ic_chip_split, true, 0x00, 0x04),
> > SCU_VARIANT("aspeed,ast2700-scu-ic2", 0, GENMASK(3, 0), 4,
> &aspeed_scu_ic_chip_split, true, 0x04, 0x00),
> > SCU_VARIANT("aspeed,ast2700-scu-ic3", 0, GENMASK(1, 0), 2,
> &aspeed_scu_ic_chip_split, true, 0x04, 0x00),
> > };
>
> You have this split_ier_isr field already, which should be good enough to select
> the chip to assign, similar to what you do with the handler, no?
Got it, thanks your feedback.
>
> Thanks,
>
> tglx
prev parent reply other threads:[~2025-09-05 8:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-31 2:14 [PATCH v2 0/4] irqchip: Add support for Aspeed AST2700 SCU interrupt controller Ryan Chen
2025-08-31 2:14 ` [PATCH v2 1/4] irqchip/aspeed-scu-ic: Refactor driver to support variant-based initialization Ryan Chen
2025-09-02 12:56 ` Thomas Gleixner
2025-09-03 10:03 ` Ryan Chen
2025-08-31 2:14 ` [PATCH v2 2/4] dt-bindings: mfd: aspeed: Add AST2700 SCU compatibles Ryan Chen
2025-09-01 20:28 ` Rob Herring (Arm)
2025-09-03 13:43 ` (subset) " Lee Jones
2025-08-31 2:14 ` [PATCH v2 3/4] dt-bindings: interrupt-controller: aspeed: Add AST2700 SCU IC compatibles Ryan Chen
2025-09-01 20:29 ` Rob Herring (Arm)
2025-08-31 2:14 ` [PATCH v2 4/4] irqchip/aspeed-scu-ic: Add support AST2700 SCU interrupt controllers Ryan Chen
2025-09-02 13:07 ` Thomas Gleixner
2025-09-05 5:55 ` Ryan Chen
2025-09-05 7:47 ` Thomas Gleixner
2025-09-05 8:57 ` Ryan Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS8PR06MB75416851138FFF2A62AFEE56F203A@OS8PR06MB7541.apcprd06.prod.outlook.com \
--to=ryan_chen@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®