From: Ryan Chen <ryan_chen@aspeedtech.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
"brendan.higgins@linux.dev" <brendan.higgins@linux.dev>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"andi.shyti@kernel.org" <andi.shyti@kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"andrew@codeconstruct.com.au" <andrew@codeconstruct.com.au>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v13 1/3] dt-bindings: i2c: aspeed: support for AST2600-i2cv2
Date: Wed, 21 Aug 2024 02:29:49 +0000 [thread overview]
Message-ID: <OS8PR06MB7541A425EF01573FCBE6735AF28E2@OS8PR06MB7541.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <266f4b55-bddb-4c44-9eb5-3eef35757714@kernel.org>
> Subject: Re: [PATCH v13 1/3] dt-bindings: i2c: aspeed: support for
> AST2600-i2cv2
>
> On 20/08/2024 08:50, Ryan Chen wrote:
> >>>> Subject: Re: [PATCH v13 1/3] dt-bindings: i2c: aspeed: support for
> >>>> AST2600-i2cv2
> >>>>
> >>>> On 19/08/2024 11:28, Ryan Chen wrote:
> >>>>> Add ast2600-i2cv2 compatible and aspeed,global-regs,
> >>>>> aspeed,enable-dma and description for ast2600-i2cv2.
> >>>>>
> >>>>> Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>
> >>>>> Reviewed-by: Krzysztof Kozlowski <krzk+dt@kernel.org>
> >>>>
> >>>> ?!?
> >>>>
> >>>> What happened here? Why are you amending tags?!? That's not
> allowed.
> >>>> You cannot change received tags, change people names or their data!
> >>>> And how is it even possible, srsly, how do you even work with git?
> >>>> Git would never do it, so you had to do it on purpose via some
> >>>> weird
> >> workflow.
> >>>>
> >>> Sorry, I don't know Krzysztof Kozlowski
> >>> <krzysztof.kozlowski@linaro.org> is
> >> you or not.
> >>> Or should I still keep Krzysztof Kozlowski <krzk+dt@kernel.org>?
> >>>
> >>> https://patches.linaro.org/project/linux-i2c/patch/20230415012848.17
> >>> 77
> >>> 768-2-ryan_chen@aspeedtech.com/
> >>
> >> Here is the tag you received. You added it in v12.
> >>
> >> Why did you change the tag suddenly to something else?
> >>
> >> Do you understand that you are not allowed to change people tags? I
> >> have doubts if you ask about people's identities, which is entirely irrelevant.
> >>
> > Sorry, I am not understood.
>
> I don't know how to say this simpler that you are not allowed to change tags.
>
> You receive tag, use b4 to apply it or add it manually. Do not alter it.
> Do not change it. Do not add things there. Do not remove parts of it.
>
> Tag is as is. You only copy and paste.
>
> Is this understood now?
>
>
>
> > https://patches.linaro.org/project/linux-i2c/patch/20230415012848.1777
> > 768-2-ryan_chen@aspeedtech.com/
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> at
> > v10 So, what should I do now at v13??
>
> Fix your workflow and go back to previous version which had correct tag.
> And answer - why did you decide to change it?
>
Sorry, I understand the tag means now.
It should keep original review-by tag. And send v14.
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2024-08-21 2:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 9:28 [PATCH v13 0/3] Add ASPEED AST2600 I2Cv2 controller driver Ryan Chen
2024-08-19 9:28 ` [PATCH v13 1/3] dt-bindings: i2c: aspeed: support for AST2600-i2cv2 Ryan Chen
2024-08-19 10:34 ` Krzysztof Kozlowski
2024-08-20 1:29 ` Ryan Chen
2024-08-20 6:18 ` Krzysztof Kozlowski
2024-08-20 6:50 ` Ryan Chen
2024-08-20 10:01 ` Krzysztof Kozlowski
2024-08-21 2:29 ` Ryan Chen [this message]
2024-08-19 9:28 ` [PATCH v13 2/3] i2c: aspeed: support AST2600 i2c new register mode driver Ryan Chen
2024-08-19 14:17 ` Andy Shevchenko
2024-08-21 6:43 ` Ryan Chen
2024-08-21 11:53 ` Andy Shevchenko
2024-08-22 2:24 ` Ryan Chen
2024-08-22 13:32 ` Andy Shevchenko
2024-08-23 6:23 ` Ryan Chen
2024-08-23 14:03 ` Andy Shevchenko
2024-08-26 7:50 ` Ryan Chen
2024-08-26 10:38 ` Andy Shevchenko
2024-08-28 2:34 ` Ryan Chen
2024-08-28 13:55 ` Andy Shevchenko
2024-08-19 15:28 ` kernel test robot
2024-08-19 17:10 ` kernel test robot
2024-08-19 9:28 ` [PATCH v13 3/3] i2c: aspeed: support AST2600 i2c new register slave " Ryan Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS8PR06MB7541A425EF01573FCBE6735AF28E2@OS8PR06MB7541.apcprd06.prod.outlook.com \
--to=ryan_chen@aspeedtech.com \
--cc=andi.shyti@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=andriy.shevchenko@linux.intel.com \
--cc=benh@kernel.crashing.org \
--cc=brendan.higgins@linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®