From: Ryan Chen <ryan_chen@aspeedtech.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Kevin Chen <kevin_chen@aspeedtech.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>
Subject: RE: [PATCH v3 2/2] irqchip: aspeed: add debugfs support and AST2700 INTC0/INTC1 routing/protection display
Date: Thu, 24 Jul 2025 02:19:14 +0000 [thread overview]
Message-ID: <OS8PR06MB7541B3BF750D9B4CB6520BCDF25EA@OS8PR06MB7541.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <87wm7yrep5.ffs@tglx>
> Subject: RE: [PATCH v3 2/2] irqchip: aspeed: add debugfs support and AST2700
> INTC0/INTC1 routing/protection display
>
> On Wed, Jul 23 2025 at 06:02, Ryan Chen wrote:
> >> > +struct aspeed_intc {
> >> > + void __iomem *base;
> >> > + struct device *dev;
> >> > + struct dentry *dbg_root;
> >> > + int (*show_routing)(struct seq_file *s, void *unused);
> >> > + int (*show_prot)(struct seq_file *s, void *unused); };
> >>
> >> See the chapter about struct declarations and initializers in the
> >> documentation I linked to above.
> >
> > Sorry, I don't see the struct "> > + int (*show_prot)(struct seq_file *s, void
> *unused); };"
>
> I fatfingered that, but that's not the problem.
>
> > My original submit is following, it should ok. Am I right?
>
> No. Read the chapter I pointed you to.
>
> > https://www.spinics.net/lists/kernel/msg5776957.html
Thanks, I think your point is align the struct member names.
Will update.
struct aspeed_intc {
void __iomem *base;
struct device *dev;
struct dentry *dbg_root;
int (*show_routing)(struct seq_file *s, void *unused);
int (*show_prot)(struct seq_file *s, void *unused);
};
>
> I have replied to this very mail. No need to paste me this and the pointer to
> some random mail archive
>
prev parent reply other threads:[~2025-07-24 2:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 9:51 [PATCH v3 0/2] irqchip: aspeed: Add AST2700 INTC debugfs support and yaml update Ryan Chen
2025-07-22 9:51 ` [PATCH v3 1/2] dt-bindings: interrupt-controller: aspeed: Add parent node compatibles and refine documentation Ryan Chen
2025-07-22 15:28 ` Thomas Gleixner
2025-07-23 7:47 ` Ryan Chen
2025-07-23 5:01 ` Rob Herring
2025-07-23 7:56 ` Ryan Chen
2025-07-23 6:11 ` Krzysztof Kozlowski
2025-07-23 8:18 ` Ryan Chen
2025-07-25 7:18 ` Ryan Chen
2025-07-25 7:41 ` Krzysztof Kozlowski
2025-07-23 6:13 ` Krzysztof Kozlowski
2025-07-23 8:08 ` Ryan Chen
2025-07-25 7:40 ` Krzysztof Kozlowski
2025-07-27 1:47 ` Ryan Chen
2025-07-27 9:36 ` Krzysztof Kozlowski
2025-07-28 2:54 ` Ryan Chen
2025-07-22 9:51 ` [PATCH v3 2/2] irqchip: aspeed: add debugfs support and AST2700 INTC0/INTC1 routing/protection display Ryan Chen
2025-07-22 15:27 ` Thomas Gleixner
2025-07-23 6:02 ` Ryan Chen
2025-07-23 17:37 ` Thomas Gleixner
2025-07-24 2:19 ` Ryan Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS8PR06MB7541B3BF750D9B4CB6520BCDF25EA@OS8PR06MB7541.apcprd06.prod.outlook.com \
--to=ryan_chen@aspeedtech.com \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=kevin_chen@aspeedtech.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®