mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Ramesh Shanmugasundaram <rashanmu@gmail.com>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Biju Das <biju.das.jz@bp.renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: RE: [PATCH v3 4/5] media: dt-bindings: media: renesas,drif: Add r8a77965 support
Date: Wed, 14 Oct 2020 14:35:24 +0000	[thread overview]
Message-ID: <OSAPR01MB274089EA87D5280E83E81C7DC2050@OSAPR01MB2740.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdUxCiwjsFRYpVND-FLajaceUf+jWK0ZBR5Rp5xJ+MPDgA@mail.gmail.com>

Hi Geert,

Thank you for your feedback!

> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 14 October 2020 14:38
> Subject: Re: [PATCH v3 4/5] media: dt-bindings: media: renesas,drif: Add
> r8a77965 support
>
> Hi Fabrizio,
>
> On Tue, Oct 13, 2020 at 5:02 PM Fabrizio Castro
> <fabrizio.castro.jz@renesas.com> wrote:
> > The r8a77965 (a.k.a. R-Car M3-N) device tree schema is
> > compatible with the already documented R-Car Gen3 devices.
> >
> > Document r8a77965 support within renesas,drif.yaml.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> > --- a/Documentation/devicetree/bindings/media/renesas,drif.yaml
> > +++ b/Documentation/devicetree/bindings/media/renesas,drif.yaml
> > @@ -53,6 +53,7 @@ properties:
> >        - enum:
> >          - renesas,r8a7795-drif        # R-Car H3
> >          - renesas,r8a7796-drif        # R-Car M3-W
> > +        - renesas,r8a77965-drif       # R-Car M3-N
> >          - renesas,r8a77990-drif       # R-Car E3
> >        - const: renesas,rcar-gen3-drif # Generic R-Car Gen3 compatible device
>
> I guess you're aware M3-N (and E3) have an extra register?
> Probably the driver just relies on its initial value, but it never hurts to be
> explicit and initialize it properly.

Yes, I am aware of the extra register, and that's reflected in the DRIF nodes
definition within the SoC specific device trees.
I'll tackle initialization and configuration of the extra register at some point,
do you think we could use the default value for now?

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647

  reply	other threads:[~2020-10-14 14:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13 15:01 [PATCH v3 0/5] Add r8a77965 DRIF support Fabrizio Castro
2020-10-13 15:01 ` [PATCH v3 1/5] MAINTAINERS: Update MAINTAINERS for Renesas DRIF driver Fabrizio Castro
2020-10-13 15:01 ` [PATCH v3 2/5] media: dt-bindings: media: renesas,drif: Convert to json-schema Fabrizio Castro
2020-10-14 13:39   ` Geert Uytterhoeven
2020-10-14 15:10     ` Fabrizio Castro
2020-10-13 15:01 ` [PATCH v3 3/5] media: dt-bindings: media: renesas,drif: Add r8a77990 support Fabrizio Castro
2020-10-13 15:01 ` [PATCH v3 4/5] media: dt-bindings: media: renesas,drif: Add r8a77965 support Fabrizio Castro
2020-10-13 20:47   ` Laurent Pinchart
2020-10-13 21:50   ` Lad, Prabhakar
2020-10-14 13:37   ` Geert Uytterhoeven
2020-10-14 14:35     ` Fabrizio Castro [this message]
2020-10-14 14:51       ` Geert Uytterhoeven
2020-10-14 16:01         ` Fabrizio Castro
2020-10-13 15:01 ` [PATCH v3 5/5] arm64: dts: r8a77965: Add DRIF support Fabrizio Castro
2020-10-13 21:51   ` Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSAPR01MB274089EA87D5280E83E81C7DC2050@OSAPR01MB2740.jpnprd01.prod.outlook.com \
    --to=fabrizio.castro.jz@renesas.com \
    --cc=Chris.Paterson2@renesas.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=rashanmu@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®