From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Arnd Bergmann <arnd@arndb.de>, Alan Stern <stern@rowland.harvard.edu>
Cc: gregkh <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Johan Hovold <johan@kernel.org>,
USB list <linux-usb@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: hide usb_of_get_companion_dev for CONFIG_USB=n
Date: Mon, 20 Aug 2018 03:22:04 +0000 [thread overview]
Message-ID: <OSBPR01MB22931014287A7641FFBFBE56D8320@OSBPR01MB2293.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAK8P3a33DRBj6ZeJBeWGnw3RnpK3rTaYtrbs6jjZ8VVPOk8=qw@mail.gmail.com>
Hi Arnd,
> From: Arnd Bergmann, Sent: Tuesday, August 14, 2018 11:27 PM
>
> On Tue, Aug 14, 2018 at 3:58 PM Alan Stern <stern@rowland.harvard.edu> wrote:
> > On Mon, 13 Aug 2018, Arnd Bergmann wrote:
> > > diff --git a/drivers/usb/gadget/udc/Kconfig b/drivers/usb/gadget/udc/Kconfig
> > > index 0a16cbd4e528..663a8bd67a7b 100644
> > > --- a/drivers/usb/gadget/udc/Kconfig
> > > +++ b/drivers/usb/gadget/udc/Kconfig
> > > @@ -193,6 +193,7 @@ config USB_RENESAS_USB3
> > > tristate 'Renesas USB3.0 Peripheral controller'
> > > depends on ARCH_RENESAS || COMPILE_TEST
> > > depends on EXTCON
> > > + depends on USB || !USB
> >
> > Is this some weird standard idiom? It looks really strange.
>
> Yes, and yes.
>
> A less common way to write it is
>
> depends on (USB != m) || m
>
> which some people prefer, but I find even weirder.
Thank you for the patch!
On other thread, John mentions gadget-side drivers should not depend on host-side [1].
So, I submitted a patch today [2]. What do you think about my submitted patch?
[1]
https://marc.info/?l=linux-usb&m=153433776202861&w=2
[2]
https://patchwork.kernel.org/patch/10569847/
Best regards,
Yoshihiro Shimoda
> Arnd
next prev parent reply other threads:[~2018-08-20 3:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 21:48 Arnd Bergmann
2018-08-14 13:58 ` Alan Stern
2018-08-14 14:26 ` Arnd Bergmann
2018-08-20 3:22 ` Yoshihiro Shimoda [this message]
2018-08-20 11:22 ` Arnd Bergmann
2018-08-21 1:59 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSBPR01MB22931014287A7641FFBFBE56D8320@OSBPR01MB2293.jpnprd01.prod.outlook.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®