From: Billy Tsai <billy_tsai@aspeedtech.com>
To: Frank Li <Frank.li@oss.nxp.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Frank Li <Frank.Li@nxp.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Philipp Zabel <p.zabel@pengutronix.de>,
"linux-i3c@lists.infradead.org" <linux-i3c@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: 回覆: [PATCH 5/8] i3c: mipi-i3c-hci: Add support for the AST2700 I3C controller
Date: Wed, 9 Sep 2026 05:38:49 +0000 [thread overview]
Message-ID: <OSQPR06MB72525B77F0B3F5D094C4F7BF8BB02@OSQPR06MB7252.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <apdBQ3GbChnlUk8b@lizhi-Precision-Tower-5810>
> > drivers/i3c/master/mipi-i3c-hci/vendor_aspeed.c | 234 ++++++++++++++++++++++++
> > drivers/i3c/master/mipi-i3c-hci/vendor_aspeed.h | 174 ++++++++++++++++++
> needn't "vendor"
Okay, I will rename vendor_aspeed.[ch] to aspeed.[ch]
> > +struct aspeed_i3c_vendor_data {
> > + void __iomem *inhouse_regs;
> > + void __iomem *phy_regs;
> > + struct reset_control *rst;
> > + struct reset_control *dma_rst;
> > + struct clk *clk;
> > +};
> should be in aspeed.c
Okay, I will move it into aspeed.c. The only place outside that file that
touches its fields directly today is the reset/clock acquisition in
probe() -- that's moving into aspeed.c as well (see below), so nothing
outside aspeed.c will need the struct layout any more.
> > +static inline bool is_aspeed(struct i3c_hci *hci)
> > +{
> > + return of_device_is_compatible(hci->master.dev.of_node,
> > + "aspeed,ast2700-i3c-hci");
> > +}
> Don't suggest is_aspeed(), you split each feature and use drvdata like
> previous QUIRK.
>
> It will become complex if new chip appear, such aspeed,ast2800-i3c-hci,
Okay, I will drop is_aspeed() and split its 9 call sites into quirk
bits set from the match table:
- HCI_QUIRK_VENDOR_BUS_SETUP: bus_init() and do_reset_and_restore()
performing vendor-specific controller setup, including clock-stall enable.
- HCI_QUIRK_BOARD_PHY_TIMINGS: bus_init() and do_reset_and_restore()
applying PHY timing settings from the board's DT properties through the
vendor-specific PHY interface. The match-table bit identifies controllers
that need this configuration path; the timing values come from DT.
- HCI_QUIRK_VENDOR_INTR_SUMMARY: reset_and_init() enabling the vendor
interrupt summary path, and probe() selecting the vendor IRQ handler
with IRQF_SHARED dropped. These have to move together: enabling the
summary path without the handler leaves vendor interrupts
unserviced.
- HCI_QUIRK_IBI_PAYLOAD_THLD: request_ibi() growing the payload IBI
termination threshold.
- HCI_QUIRK_VENDOR_RESOURCES: probe() allocating the vendor_data struct
and acquiring the reset lines/clock -- this moves into aspeed.c
wholesale, so core.c's probe() just calls one function gated by this
bit instead of touching the struct's fields.
- HCI_QUIRK_VENDOR_DAA_INDEX: the ENTDAA loop writing the DAT slot
index into the vendor DAA index register.
- HCI_QUIRK_VENDOR_TX_AVAIL: the PIO TX path using the vendor FIFO
pointer registers instead of the generic STAT_TX_THLD bit.
Billy
next prev parent reply other threads:[~2026-09-09 5:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 11:35 [PATCH 0/8] i3c: mipi-i3c-hci: Add Aspeed AST2700 support Billy Tsai
2026-09-01 11:35 ` [PATCH 1/8] dt-bindings: i3c: Document the AST2700 I3C controller Billy Tsai
2026-09-01 20:41 ` Frank Li
2026-09-09 5:33 ` 回覆: " Billy Tsai
2026-09-07 6:28 ` Krzysztof Kozlowski
2026-09-09 5:35 ` 回覆: " Billy Tsai
2026-09-17 15:47 ` Alexandre Belloni
2026-09-24 5:39 ` 回覆: " Billy Tsai
2026-09-30 15:26 ` Alexandre Belloni
2026-09-01 11:35 ` [PATCH 2/8] i3c: mipi-i3c-hci: Support address-indexed DAT slots Billy Tsai
2026-09-01 20:47 ` Frank Li
2026-09-09 5:36 ` 回覆: " Billy Tsai
2026-09-01 11:35 ` [PATCH 3/8] i3c: mipi-i3c-hci: Add a quirk for 64-bit DMA addressing Billy Tsai
2026-09-01 20:51 ` Frank Li
2026-09-09 5:37 ` 回覆: " Billy Tsai
2026-09-01 11:35 ` [PATCH 4/8] i3c: mipi-i3c-hci: Add a quirk to clear the TX start threshold Billy Tsai
2026-09-01 20:58 ` Frank Li
2026-09-09 5:37 ` 回覆: " Billy Tsai
2026-09-01 11:35 ` [PATCH 5/8] i3c: mipi-i3c-hci: Add support for the AST2700 I3C controller Billy Tsai
2026-09-01 21:18 ` Frank Li
2026-09-09 5:38 ` Billy Tsai [this message]
2026-11-04 11:14 ` Philipp Zabel
2026-09-01 11:35 ` [PATCH 6/8] i3c: mipi-i3c-hci: Program AST2700 IBI termination threshold Billy Tsai
2026-09-01 11:35 ` [PATCH 7/8] i3c: mipi-i3c-hci: Improve AST2700 PIO TX queue utilization Billy Tsai
2026-09-01 11:35 ` [PATCH 8/8] i3c: mipi-i3c-hci: Support the AST2700 internal pull-ups Billy Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSQPR06MB72525B77F0B3F5D094C4F7BF8BB02@OSQPR06MB7252.apcprd06.prod.outlook.com \
--to=billy_tsai@aspeedtech.com \
--cc=Frank.Li@nxp.com \
--cc=Frank.li@oss.nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®