mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Billy Tsai <billy_tsai@aspeedtech.com>
To: Conor Dooley <conor@kernel.org>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
	Andrew Jeffery <andrew@codeconstruct.com.au>,
	Linus Walleij <linusw@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Ryan Chen <ryan_chen@aspeedtech.com>,
	Andrew Jeffery <andrew@aj.id.au>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v7 1/3] dt-bindings: pinctrl: Add aspeed,ast2700-soc0-pinctrl
Date: Mon, 20 Apr 2026 07:22:57 +0000	[thread overview]
Message-ID: <OSQPR06MB7252BD7967D2567AD6DA7A1D8B2F2@OSQPR06MB7252.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <20260417-anemia-borrower-fb90ac02b417@spud>

> > > > +    properties:
> > > > +      function:
> > > > +        enum:
> > > > +          - EMMC
> > > > +          - JTAGDDR
> > > > +          - JTAGM0
> > > > +          - JTAGPCIEA
> > > > +          - JTAGPCIEB
> > > > +          - JTAGPSP
> > > > +          - JTAGSSP
> > > > +          - JTAGTSP
> > > > +          - JTAGUSB3A
> > > > +          - JTAGUSB3B
> > > > +          - PCIERC0PERST
> > > > +          - PCIERC1PERST
> > > > +          - TSPRSTN
> > > > +          - UFSCLKI
> > > > +          - USB2AD0
> > > > +          - USB2AD1
> > > > +          - USB2AH
> > > > +          - USB2AHP
> > > > +          - USB2AHPD0
> > > > +          - USB2AXH
> > > > +          - USB2AXH2B
> > > > +          - USB2AXHD1
> > > > +          - USB2AXHP
> > > > +          - USB2AXHP2B
> > > > +          - USB2AXHPD1
> > > > +          - USB2BD0
> > > > +          - USB2BD1
> > > > +          - USB2BH
> > > > +          - USB2BHP
> > > > +          - USB2BHPD0
> > > > +          - USB2BXH
> > > > +          - USB2BXH2A
> > > > +          - USB2BXHD1
> > > > +          - USB2BXHP
> > > > +          - USB2BXHP2A
> > > > +          - USB2BXHPD1
> > > > +          - USB3AXH
> > > > +          - USB3AXH2B
> > > > +          - USB3AXHD
> > > > +          - USB3AXHP
> > > > +          - USB3AXHP2B
> > > > +          - USB3AXHPD
> > > > +          - USB3BXH
> > > > +          - USB3BXH2A
> > > > +          - USB3BXHD
> > > > +          - USB3BXHP
> > > > +          - USB3BXHP2A
> > > > +          - USB3BXHPD
> > > > +          - VB
> > > > +          - VGADDC
> > > > +
> > > > +      groups:
> > > > +        enum:
> > > > +          - EMMCCDN
> > > > +          - EMMCG1
> > > > +          - EMMCG4
> > > > +          - EMMCG8
> > > > +          - EMMCWPN
> > > > +          - JTAG0
> > > > +          - PCIERC0PERST
> > > > +          - PCIERC1PERST
> > > > +          - TSPRSTN
> > > > +          - UFSCLKI
> > > > +          - USB2A
> > > > +          - USB2AAP
> > > > +          - USB2ABP
> > > > +          - USB2ADAP
> > > > +          - USB2AH
> > > > +          - USB2AHAP
> > > > +          - USB2B
> > > > +          - USB2BAP
> > > > +          - USB2BBP
> > > > +          - USB2BDBP
> > > > +          - USB2BH
> > > > +          - USB2BHBP
> > > > +          - USB3A
> > > > +          - USB3AAP
> > > > +          - USB3ABP
> > > > +          - USB3B
> > > > +          - USB3BAP
> > > > +          - USB3BBP
> > > > +          - VB0
> > > > +          - VB1
> > > > +          - VGADDC
> > > > +      pins:
> > > > +        enum:
> > > > +          - AB13
> > > > +          - AB14
> > > > +          - AC13
> > > > +          - AC14
> > > > +          - AD13
> > > > +          - AD14
> > > > +          - AE13
> > > > +          - AE14
> > > > +          - AE15
> > > > +          - AF13
> > > > +          - AF14
> > > > +          - AF15

> > > Why do you have groups and pins?
> > > Is it valid in your device to have groups and pins in the same node?

> > The intent is to support both group-based mux selection and
> > configuration, as well as per-pin configuration.

> > In our hardware:
> > - `function` + `groups` are used for pinmux selection.
> > - `pins` is used for per-pin configuration (e.g. drive strength,
> >   bias settings).
> > - `groups` may also be used for group-level configuration.

> > As a result, both `groups` and `pins` may appear in the same node,
> > but they serve different purposes and do not conflict:
> > - `groups` selects the mux function and may apply configuration to
> >   the entire group.
> > - `pins` allows overriding or specifying configuration for individual
> >   pins.

> > In most cases, only one of them is needed, but both are allowed when
> > both group-level and per-pin configuration are required.

> To be honest, that sounds like your groups are not sufficiently
> granular and should be reduced such that you can use them for pin
> settings.

The intent was to keep the binding flexible, but in practice the mixed
use of `groups` and `pins` in the same node is not expected to be used.

Given that, I agree this flexibility is unnecessary and makes the
binding semantics less clear. I'll rework the binding to make the
expected usage explicit rather than allowing combinations that do not
correspond to a real use case.

In particular, I'll split the constraints as follows:

- For pinmux, the presence of `function` will require `groups`, and
  `pins` will not be allowed. This reflects the hardware design, where
  the groups are defined by the pins affected by a given mux expression

- For pin configuration, exactly one of `groups` or `pins` will be
  required (using oneOf), so that configuration is applied either at
  group level or per-pin, but not both.


- if:
    required:
      - function
  then:
    required:
      - groups
    not:
      required:
        - pins
  else:
    oneOf:
      - required:
          - groups
        not:
          required:
            - pins
      - required:
          - pins
        not:
          required:
            - groups
Does this match what you had in mind?

Thanks
Billy Tsai

  reply	other threads:[~2026-04-20  7:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16  7:29 [PATCH v7 0/3] pinctrl: aspeed: Add AST2700 SoC0 support Billy Tsai
2026-04-16  7:29 ` [PATCH v7 1/3] dt-bindings: pinctrl: Add aspeed,ast2700-soc0-pinctrl Billy Tsai
2026-04-16 15:54   ` Conor Dooley
2026-04-17  2:20     ` Billy Tsai
2026-04-17 16:06       ` Conor Dooley
2026-04-20  7:22         ` Billy Tsai [this message]
2026-04-20 16:25           ` Conor Dooley
2026-04-21  6:15             ` Billy Tsai
2026-04-21 17:57               ` Conor Dooley
2026-04-22  2:30                 ` Andrew Jeffery
2026-04-23 17:44           ` Conor Dooley
2026-04-16  7:29 ` [PATCH v7 2/3] dt-bindings: mfd: aspeed,ast2x00-scu: Describe AST2700 SCU0 Billy Tsai
2026-04-21 18:39   ` Rob Herring
2026-04-22  1:06     ` Billy Tsai
2026-04-16  7:29 ` [PATCH v7 3/3] pinctrl: aspeed: Add AST2700 SoC0 support Billy Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSQPR06MB7252BD7967D2567AD6DA7A1D8B2F2@OSQPR06MB7252.apcprd06.prod.outlook.com \
    --to=billy_tsai@aspeedtech.com \
    --cc=andrew@aj.id.au \
    --cc=andrew@codeconstruct.com.au \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=conor@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh@kernel.org \
    --cc=ryan_chen@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®