From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from TYDPR03CU002.outbound.protection.outlook.com (mail-japaneastazon11023076.outbound.protection.outlook.com [52.101.127.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C43EB2DE6F8 for ; Thu, 9 Apr 2026 01:31:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.127.76 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775698294; cv=fail; b=YT0JVMlKlQFanVKCLaNWpZclFIusydqN+5lUjDx7YKC8rJHZh+Mr7zqX+gnOHyQGls+Nik2oxsQ5uS/FSCtPHE/VweBaIpZYiNFlGC/WfQM1zEsoGP3dlSJ2hA0D/PkKPPDmsU7/KRfwsrd9p8l+BRLVs+iOptcEjJSKy4WmhZk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775698294; c=relaxed/simple; bh=qwLVhcuZ3PFgPzl1bVSZgmxOzgcND1pqcvJVQuxMyWM=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=G8N2Abj3VJ3CgAvg6mEYYJqwymK3MhCaAoAACWaj/Iayw7jt3Shz0lj/KJt0S59bSiqrqbezLY2YlElteQvAOmdBLNxjBBI6BAm9H2FVIPBQRw5t9InuzWMwv1n6qUnmzGLjL15kdrTyFSOTTu9zNVakIMaACbClDaXlFTxbijM= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=aspeedtech.com; spf=pass smtp.mailfrom=aspeedtech.com; dkim=pass (2048-bit key) header.d=aspeedtech.com header.i=@aspeedtech.com header.b=cLDFjg/W; arc=fail smtp.client-ip=52.101.127.76 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=aspeedtech.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=aspeedtech.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=aspeedtech.com header.i=@aspeedtech.com header.b="cLDFjg/W" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VITXhYM7sJ7OHpAzTZDVnRJnVjARoY5z+kMQtBrfcSsszvmzEUlqE4d8D3vpgz9+oCRLi8ezQAqRK4qJzUf2wrx7t5pHR+9DUNQx+kPQx6O6x99Ies0XhjCPpGprMq63ZbLhyb81AFLQKi+ryOE5jblqjp8j8cm96VyrM4bXjCuCUEtAlOULwMGzKguh6eZT8Qf6nMfmQwO1JvdXLk2ED9P+O76IawxQvtdH69r4zojSB0XMG+ZV0WZkOSAiwpytjVh2KnKTeJ7GC1ELNVmuSlckMA9OwrV+hWlTKETJ0n/YXzwr4coYLAIrXTGeS6lpW/+UEXumuvDskyAA8IXMyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SjZF4z8QTJNppREGxIR3cDj+83orE2VhK90Hoq1yEdM=; b=lgqYHW9Hq0rQevYWs8Q0XiSM69tNs6HEr/2kGfmh4IcfBfquYxIB/invOJlWwMDM2sEYy1UJBekkiL7O+75UG36q14ErADYVqEZq7VDa/BIvH2PWsv17rKCexAkgTz7BnY0FZt4sge4eJeq5xwi7y9NiGIDzjY9flV+aJUzxwhWrNJQQkCDvC/fIgomq8pkJLvRkx/uHbgdlCawqYb+g+PCWPeC2vDBGKQj0cKjJ32h6Y2VOkmNkAx4yxNWF+Ac/GI9QN8H08yc0HJzEQOg5Sy5bfQB40b3WsxUW17Z0ZkmcBfLlYwALf/59p95fuMD95mDkWwuhVqXpkTs7bXPUSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=aspeedtech.com; dmarc=pass action=none header.from=aspeedtech.com; dkim=pass header.d=aspeedtech.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aspeedtech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SjZF4z8QTJNppREGxIR3cDj+83orE2VhK90Hoq1yEdM=; b=cLDFjg/W/Clhzo2qYzPcg8XKnkIH8FFClWAYkltEzNB9w43zwdyFUcRm2k0HwEmF2ARIgdB6KuzrWP0ARWsIr0y+Yu/YuN7rKvpWqbwa9rwJBYOgaMmrbUhKMeEv+8W0RQpxoUVZaTd7MIpBYczyDR4MSWjYTKqYEumVKoUlyBH8y/0DPd0tcARImojeSkmCHhh4eX9/5pJXtMZCGt5ZMrREU5xD/0Y1pKDUrKiAFpazJ6QJHCT3ZgdC5qkxlhohwXw/wuDRFJqPDbMJxZVUOLMUw6V5Y+IPNKD4ogx8Gt9AImTfpUNkQvSYUAjeHrErBrgqcdaNOJtQ/+aBD1eIgA== Received: from OSQPR06MB7252.apcprd06.prod.outlook.com (2603:1096:604:29c::6) by SEZPR06MB5197.apcprd06.prod.outlook.com (2603:1096:101:70::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.18; Thu, 9 Apr 2026 01:31:16 +0000 Received: from OSQPR06MB7252.apcprd06.prod.outlook.com ([fe80::92af:c9d9:8779:d19]) by OSQPR06MB7252.apcprd06.prod.outlook.com ([fe80::92af:c9d9:8779:d19%4]) with mapi id 15.20.9769.015; Thu, 9 Apr 2026 01:31:16 +0000 From: Billy Tsai To: Frank Li CC: Alexandre Belloni , Nicolas Pitre , Boris Brezillon , "linux-i3c@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] i3c: mipi-i3c-hci: fix IBI payload length calculation for final status Thread-Topic: [PATCH v2] i3c: mipi-i3c-hci: fix IBI payload length calculation for final status Thread-Index: AQHcxmwFvtzQ1a5bfUSce5jTo+DNIrXUyOKAgAEp7xg= Date: Thu, 9 Apr 2026 01:31:16 +0000 Message-ID: References: <20260407-i3c-hci-dma-v2-1-a583187b9d22@aspeedtech.com> In-Reply-To: Accept-Language: en-US, zh-TW Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=aspeedtech.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: OSQPR06MB7252:EE_|SEZPR06MB5197:EE_ x-ms-office365-filtering-correlation-id: 8f85ad24-86ff-4ab2-baf5-08de95d7b191 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0;ARA:13230040|376014|366016|1800799024|38070700021|56012099003|22082099003|13003099007|18002099003; x-microsoft-antispam-message-info: wOjcGu68Ng1YkxIHYnHarv1pl0jNVGJwzHKHqNw5RrC/rc9YLjFPRvgbqBJ0RMuqB8h5m4rKIkISzCuSHHOjTmSIIE0N1rNIe1HFzBCuqzN4gZ6QYaCCBhV2s57AunKjpT4m6fEZ+cdCemEyj+0i++TkCKRRBLnQ/6MtxQiPO0papugS1620+bDhhdRnjW8rjhmCtpj9XWj8xsxXumgXbmvvF5BRsWHna84os2Xbd7UWB8iNs82Z3DseOeUDAOkIZaFbDNln5OQ+o4v4QBpTKJOhIsuHD3Mcr8PLxsiU/4ffE4nSc1WHi4cLeiSo3VbeccHIkFvFZ6pyowhcZYn28lbWPdDBrD21hKwIUFIuMZBkBHnP25UFQAj739t/aQenLfROjie2dHnvVF8R7Bjeda4cQgc3EmGFFDdxp2I+fdxF88mdsa6/rTROuhZ15TJvBrD7cjeogzN/Gp8FjmPiCWq+vb2yzD/ZEAsOGMD2/9AmAZRVubE/50wQ/wnL643JEw7S630OE9fJB5qpdGOGJGEVJ5NZ6uypQy/a3KCXb6KuPr74Iuv2wUWEUBPI3AZKfL66fJY78F14HXUGCc6BFKrJtPkryoKewuiY7m8y2tX57caQABk7BqVNiVHSSBZOr4WjboSgT+caEY2qbMv9X2MHF6XPrMKHEbUF90odziDZ7EIeFHoCIAxR+fVnJrnZUOTl1YhUd0tZP4nQYNKIO31DA/6gZYu7z5wel+WRNzXsAiby/Q26wfUWK+mdhpW78x7jOa+73Osly2S7DW8MqR4Twz31FjgECZ7yNbaefG0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:OSQPR06MB7252.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(1800799024)(38070700021)(56012099003)(22082099003)(13003099007)(18002099003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?fcpmxu/JvqEeQPtDXKmOskwIIWBYkxG2Egkt0eS0PkXPQGBWTkErfojdCF?= =?iso-8859-1?Q?b0URTZFxKW1qDEba++uCp0e+PrFY5aSY05KPtYlXBMsWoCUU0olrcfwjUn?= =?iso-8859-1?Q?kYtz9yl+NsCUIDpiTHuikmGN1FDuEYNv/phsk+PZpnWxL2KblfVTUGlExI?= =?iso-8859-1?Q?ImKWyr0qGsne7zIrRBVjm8RdrFz7P6kwAP0Ow+o/Gzj8APmLdx/I2eggFr?= =?iso-8859-1?Q?pbqrDP1n3LrGaLXJHeO9OvBywgj9YcKpyS547dvMtZ7UElYgf6WMymD2vC?= =?iso-8859-1?Q?o1esb57eyKW2JKty3BvwT+vg6i89noURiQWWrQVdJGcag3L2rnJN0l3xkV?= =?iso-8859-1?Q?d8d3z09jr6RH9YawEOYQHdDfZ0y2bhdOEusWseeYmGNeya6uOrOiv4eRdu?= =?iso-8859-1?Q?y/e1ur35SK3l+b2RovGWA8ayzBTh8NRUU10pyf7iDCMsflSzSU8S8sq7BF?= =?iso-8859-1?Q?Cu5flyE4wzUX4/onr+gOPdO1HGKZjS6ovMEKKafoe9sG4YowlnUoKlrRMv?= =?iso-8859-1?Q?/pOlgpFwOUISMW4otCGKthUU3KL/2EoDMrNuNLHXEkNxr7uZgBdIO7nm6P?= =?iso-8859-1?Q?+ykXclVoLXozjZq1h8MsAeI9/q+aS+KN4oXl+e68HysWwVzIxVKwMvP8M3?= =?iso-8859-1?Q?IduDzydenx0m+BxlKv5evsXOeeZIkrrD2uBD2eSnCS06KtGG/qU9SdQJ8c?= =?iso-8859-1?Q?PPCa64sNJ1CTdN+WVB+wnPaSmWhlm0hPJePBKveIZYnpI1EC2cK9lvmjGN?= =?iso-8859-1?Q?WSOKlRq4s9/dXgF850m2/IR2Z8ubHt7lqtYrmiKB/cAZW8S+5KEiC/4DXY?= =?iso-8859-1?Q?hDK22VerdnHhshYDvYm8WrUnIwQqtteiS7dq4rigBpNIIeVZuW9QmtkOPl?= =?iso-8859-1?Q?1AmwwkAZPIhsSFEVZKaIZMsAmPR1Ce+oE/5JRNRyO7QYQeKVTDen+vW+q7?= =?iso-8859-1?Q?7O4+B+E1P4b+yXdPDfn5/v1XaJb52yDtK/KLyn6AdaohGqkxTugmHOR09U?= =?iso-8859-1?Q?98bOhx4TkHyIOLmvyvTpipJf6812lUEY3t/bDbiYW5h5TEFY40V6wYp+lV?= =?iso-8859-1?Q?V8QD1Q/w4kdqOmbQywYoo1yffHRLLCfhjAYEi5c2de6p/Zh/Q6KNkN/uGT?= =?iso-8859-1?Q?g7np1I11iYl5lw4+QYo0Hnd8ioby6KYezfDQsZbv3MHvVEknRPKrsfGMml?= =?iso-8859-1?Q?vrBOvrzZwmdTT/cadAt56JBaYOm6ex8304OoyK3F+oyV/QzHkDxsbacuzV?= =?iso-8859-1?Q?qAEXY9ZbtAPD3hubcSuIw+8VBtmiP88p+uYUydPUs4G6VyIS0V7SfLbF7Y?= =?iso-8859-1?Q?MDRZ+TWUWOZlq6sZMH1X9xtUc69mYxOK9rkh2EUz0snte8QzOu437zr9cG?= =?iso-8859-1?Q?kV5Xp1Bl9iqfw1H+A64+kErzVCCC8QdmMYYWdCK2ddG12MHIlU38zU/WmO?= =?iso-8859-1?Q?wmyY66GQXV+hzGfk34epT+Ejc27gojBYBiMP20MfOn03OKU2HGLeYEhRAg?= =?iso-8859-1?Q?vIsdutGfXtHCSuSBIleybYd3qcARHlyJt0oju6Ql9ZjRjFDuyxU454qcdk?= =?iso-8859-1?Q?ficHbrSBQyqi9vO/YTbsnbmjmOiZLkUCO+CBENDlOO6wBVxJxZ1he+VYPS?= =?iso-8859-1?Q?GmN8u7YTMc9PNi/Ggcl4OYfnfXpCQVu2lhBRlwXoPbGY/5h2iZbGbhX/QW?= =?iso-8859-1?Q?3A/io/sf9FwGVrxghD7MlVt6xigxIEu0+r4mIxI/LmW4MDR6QBw+cREBIX?= =?iso-8859-1?Q?4XfF/0HRRSIkoDM8fudtKYiHZY3MLFOHlUXCJgGLh7UsRhhb5JtSxAAnSz?= =?iso-8859-1?Q?r4NxncbUbw=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-OriginatorOrg: aspeedtech.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: OSQPR06MB7252.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f85ad24-86ff-4ab2-baf5-08de95d7b191 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Apr 2026 01:31:16.2352 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43d4aa98-e35b-4575-8939-080e90d5a249 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oDhSSPHdPHUPrUyUTZX3jzhcYnNh3Y/Jc8UIsFYTc5eSYVV/CK3ON0M7TvbGx/vk5JbUoJkMpBJuEinFhCs5Tk9vha8XPBbd7TAVw+H5NeM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB5197 =0A= > > In DMA mode, the IBI status descriptor encodes the payload using=0A= > > CHUNKS (number of chunks) and DATA_LENGTH (valid bytes in the last=0A= > > chunk). All preceding chunks are implicitly full-sized.=0A= > >=0A= > > The current code accumulates full chunk sizes for non-final status=0A= > > descriptors, but for the final status descriptor it only adds=0A= > > DATA_LENGTH. This ignores the contribution of the preceding full=0A= > > chunks described by the same final status entry.=0A= > >=0A= > > As a result, the computed IBI payload length is truncated whenever=0A= > > the final status spans multiple chunks. For example, with a chunk=0A= > > size of 4 bytes, CHUNKS=3D2 and DATA_LENGTH=3D1 should result in a tota= l=0A= > > payload size of 5 bytes, but the current code reports only 1 byte.=0A= > >=0A= > > Fix the calculation by adding the size of (CHUNKS - 1) full chunks=0A= > > plus DATA_LENGTH for the last chunk.=0A= > >=0A= > > Fixes: 9ad9a52cce28 ("i3c/master: introduce the mipi-i3c-hci driver")= =0A= > > Signed-off-by: Billy Tsai =0A= > > ---=0A= > > Changes in v2:=0A= > > - EDITME: describe what is new in this series revision.=0A= > > - EDITME: use bulletpoints and terse descriptions.=0A= > > - Link to v1: https://lore.kernel.org/r/20260331-i3c-hci-dma-v1-1-e5cd2= 95c44ff@aspeedtech.com=0A= > > ---=0A= > > Changes in v2:=0A= > > - Fix IBI processing logic to properly handle IBIs without data payload= .=0A= > > - Link to v1: https://lore.kernel.org/r/20260331-i3c-hci-dma-v1-1-e5cd2= 95c44ff@aspeedtech.com=0A= > > ---=0A= > > drivers/i3c/master/mipi-i3c-hci/dma.c | 5 ++++-=0A= > > 1 file changed, 4 insertions(+), 1 deletion(-)=0A= > >=0A= > > diff --git a/drivers/i3c/master/mipi-i3c-hci/dma.c b/drivers/i3c/master= /mipi-i3c-hci/dma.c=0A= > > index b903a2da1fd1..c7272155c486 100644=0A= > > --- a/drivers/i3c/master/mipi-i3c-hci/dma.c=0A= > > +++ b/drivers/i3c/master/mipi-i3c-hci/dma.c=0A= > > @@ -721,7 +721,10 @@ static void hci_dma_process_ibi(struct i3c_hci *hc= i, struct hci_rh_data *rh)=0A= > > if (!(ibi_status & IBI_LAST_STATUS)) {=0A= > > ibi_size +=3D chunks * rh->ibi_chunk_sz;=0A= > > } else {=0A= > > - ibi_size +=3D FIELD_GET(IBI_DATA_LENGTH, ibi_stat= us);=0A= > > + if (chunks) {=0A= > > + ibi_size +=3D (chunks - 1) * rh->ibi_chun= k_sz;=0A= > > + ibi_size +=3D FIELD_GET(IBI_DATA_LENGTH, = ibi_status);=0A= =0A= > this should be added to ibi_size reguardless chucks.=0A= > =0A= > if (chunks)=0A= > ibi_size +=3D (chunks - 1) * rh->ibi_chunk_sz;=0A= > =0A= > ibi_size +=3D FIELD_GET(IBI_DATA_LENGTH, ibi_status);=0A= =0A= According to the HCI spec, CHUNKS represents the number of valid data=0A= chunks in the IBI Data Ring, while DATA_LENGTH (in DMA mode) represents=0A= the number of valid bytes in the last data chunk.=0A= =0A= This implies that DATA_LENGTH is only meaningful when at least one=0A= chunk exists. If CHUNKS =3D=3D 0, there is no "last data chunk", and thus= =0A= DATA_LENGTH is expected to be 0.=0A= =0A= So a combination of CHUNKS =3D=3D 0 with a non-zero DATA_LENGTH would be=0A= an invalid descriptor encoding.=0A= =0A= To follow your suggestion and still keep the logic robust, we can=0A= always account DATA_LENGTH, but add a defensive check for this=0A= invalid condition:=0A= =0A= if (chunks)=0A= ibi_size +=3D (chunks - 1) * rh->ibi_chunk_sz;=0A= =0A= if (unlikely(!chunks &&=0A= FIELD_GET(IBI_DATA_LENGTH, ibi_status)))=0A= WARN_ON(1);=0A= =0A= ibi_size +=3D FIELD_GET(IBI_DATA_LENGTH, ibi_status);=0A= =0A= This way we handle the normal case as expected, while still catching=0A= any invalid encoding from the controller.=0A= =0A= Thanks=0A= =0A= Billy Tsai=0A=