mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shengyu Qu <wiagn233@outlook.com>
To: Ido Schimmel <idosch@nvidia.com>
Cc: wiagn233@outlook.com, razor@blackwall.org, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	horms@kernel.org, bridge@lists.linux.dev, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH net-next v2] net: bridge: locally receive all multicast packets if IFF_ALLMULTI is set
Date: Mon, 14 Apr 2025 18:42:56 +0800	[thread overview]
Message-ID: <OSZPR01MB8434D0CB20CCDB33D1D9DB2098B32@OSZPR01MB8434.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <Z_zKfOHxHRr0EC5Q@shredder>


[-- Attachment #1.1.1: Type: text/plain, Size: 2035 bytes --]



在 2025/4/14 16:42, Ido Schimmel 写道:
> On Sat, Apr 12, 2025 at 09:16:13PM +0800, Shengyu Qu wrote:
>> If multicast snooping is enabled, multicast packets may not always end up
>> on the local bridge interface, if the host is not a member of the multicast
>> group. Similar to how IFF_PROMISC allows all packets to be received
>> locally, let IFF_ALLMULTI allow all multicast packets to be received.
> 
> Would be good to explain in the commit message why this is needed when
> you can instead configure the bridge as a router port. Felix provided
> useful information on v1:
> 
> https://lore.kernel.org/netdev/7932cd23-571e-4646-b5dd-467ec8106695@nbd.name/
Hi,

Thanks for reply. I'll add that in next version.

> 
>>
>> Signed-off-by: Felix Fietkau <nbd@nbd.name>
>> Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
>> ---
>> Since Felix didn't send v2 for this patch, I decided to do it by myself.
> 
> Felix provided his SoB on v2? If not, "Reported-by" might be more
> appropriate.
Will change.
> 
>>
>> Changes since v1:
>>   - Move to net-next
>>   - Changed code according to Nikolay's advice
>> ---
>>   net/bridge/br_input.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c
>> index 232133a0fd21..aefcc3614373 100644
>> --- a/net/bridge/br_input.c
>> +++ b/net/bridge/br_input.c
>> @@ -189,7 +189,8 @@ int br_handle_frame_finish(struct net *net, struct sock *sk, struct sk_buff *skb
>>   		if ((mdst || BR_INPUT_SKB_CB_MROUTERS_ONLY(skb)) &&
>>   		    br_multicast_querier_exists(brmctx, eth_hdr(skb), mdst)) {
>>   			if ((mdst && mdst->host_joined) ||
>> -			    br_multicast_is_router(brmctx, skb)) {
>> +			    br_multicast_is_router(brmctx, skb) ||
>> +				(br->dev->flags & IFF_ALLMULTI)) {
> 
> The alignment here is off. Also, you can drop the parenthesis.
Will fix.

> 
>>   				local_rcv = true;
>>   				DEV_STATS_INC(br->dev, multicast);
>>   			}
>> -- 
>> 2.43.0
>>


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 6977 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

      reply	other threads:[~2025-04-14 10:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-12 13:16 Shengyu Qu
2025-04-14  8:42 ` Ido Schimmel
2025-04-14 10:42   ` Shengyu Qu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OSZPR01MB8434D0CB20CCDB33D1D9DB2098B32@OSZPR01MB8434.jpnprd01.prod.outlook.com \
    --to=wiagn233@outlook.com \
    --cc=bridge@lists.linux.dev \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®