From: Ramses <ramses@well-founded.dev>
To: Netdev Bot+sashiko <netdev-bot+sashiko@kernel.org>
Cc: Jv <jv@jvosburgh.net>, Andrew+netdev <andrew+netdev@lunn.ch>,
Davem <davem@davemloft.net>, Kuba <kuba@kernel.org>,
Pabeni <pabeni@redhat.com>, Jbohac <jbohac@suse.cz>,
Edumazet <edumazet@kernel.org>, Netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Razor <razor@blackwall.org>, Liuhangbin <liuhangbin@kylinos.cn>
Subject: Re: [PATCH net v3] bonding: fix initial last_rx vs ARP-monitor slack window
Date: Wed, 28 Oct 2026 16:36:13 +0100 (CET) [thread overview]
Message-ID: <P528ptp--R-9@well-founded.dev> (raw)
In-Reply-To: <179319031668.3134.15966773474485635933@kernel.org>
Oct 28, 2026, 13:25 by netdev-bot+sashiko@kernel.org:
>
> [Severity: Medium]
> Just after this hunk, bond_enslave() copies the same value into last_tx:
>
> new_slave->last_tx = new_slave->last_rx;
>
> So last_tx now also starts two intervals old. Could that cause a spurious
> UP->DOWN transition in bond_loadbalance_arp_mon(), used by balance-rr,
> balance-xor and broadcast with arp_interval set?
>
>
This has already been fixed in v4 of this patch series which I sent this morning.
v4 only uses the older seed for a slave that starts DOWN, and patch 2 of v4 seeds a slave that starts UP with last_link_up, so last_tx gets a full arp_missed_max window too.
See: https://lore.kernel.org/netdev/20261028-bonding-last-rx-v4-0-4d8e4cd47467@well-founded.dev/
Ramses
prev parent reply other threads:[~2026-10-28 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-27 12:23 Ramses de Norre via B4 Relay
2026-10-27 14:33 ` Jay Vosburgh
2026-10-28 12:25 ` netdev-bot+sashiko
2026-10-28 15:36 ` Ramses [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=P528ptp--R-9@well-founded.dev \
--to=ramses@well-founded.dev \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=jbohac@suse.cz \
--cc=jv@jvosburgh.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@kylinos.cn \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®