mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Hawkins, Nick" <nick.hawkins@hpe.com>
To: Arnd Bergmann <arnd@arndb.de>, "Verdun, Jean-Marie" <verdun@hpe.com>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
	Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Joel Stanley <joel@jms.id.au>
Subject: RE: [PATCH v1] ARM: A9: Add ARM ERRATA 764319 workaround
Date: Tue, 10 May 2022 13:41:10 +0000	[thread overview]
Message-ID: <PH0PR84MB171846CCF58FC36A39C39EF388C99@PH0PR84MB1718.NAMPRD84.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <CAK8P3a0OS+4XTG9VmfPwbuQoT+_G5-fSatbJ0g8Y7Y+O6-3YLQ@mail.gmail.com>


On Tue, May 10, 2022 at 1:53 PM Verdun, Jean-Marie <verdun@hpe.com> wrote:
> >
> > Hi Arnd,
> >
> > >    Hi Nick,
> >
> > >    This seems a bit more complex than necessary. Can't you just use a custom
> >    inline asm with an ex_table entry to catch the fault? Have a look at
> >    __get_user_asm() for an example.
> >
> >           Arnd
> >
> > We got inspired from debug_reg_hook within the same source file ( 
> >./arch/arm/kernel/hw_breakpoint.c ). We chose that path to keep 
> >coherency  within the source code. We can implement the same fix by 
> >using an ex_table  entry, but this will create two different ways at 
> >catching unknown instruction  within the same source file. Will that be ok ?

> I got a little lost trying to find where the breakpoint instruction comes from that gets trapped here, but I would guess that they had to do this using an undef_hook because the ex_table approach does not work there for some reason.

> I would still pick the ex_table method here if that works.

I will pursue the method you have recommended Arnd.

Thank you for the feedback as always.

-Nick Hawkins

  reply	other threads:[~2022-05-10 14:30 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-06 19:29 nick.hawkins
2022-05-10  7:19 ` Arnd Bergmann
2022-05-10  9:47   ` Robin Murphy
2022-05-10 11:53   ` Verdun, Jean-Marie
2022-05-10 13:01     ` Arnd Bergmann
2022-05-10 13:41       ` Hawkins, Nick [this message]
2022-05-10 14:11       ` Will Deacon
2022-05-11 12:23         ` Hawkins, Nick
2022-05-11 12:45           ` Arnd Bergmann
2022-05-11 12:59             ` Verdun, Jean-Marie
2022-05-11 13:16               ` Arnd Bergmann
2022-05-11 14:28             ` Russell King (Oracle)
2022-05-11 14:31               ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR84MB171846CCF58FC36A39C39EF388C99@PH0PR84MB1718.NAMPRD84.PROD.OUTLOOK.COM \
    --to=nick.hawkins@hpe.com \
    --cc=arnd@arndb.de \
    --cc=joel@jms.id.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=verdun@hpe.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®