mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chen Wang <unicorn_wang@outlook.com>
To: Inochi Amaoto <inochiama@gmail.com>
Cc: Chen Wang <unicornxw@gmail.com>,
	u.kleine-koenig@baylibre.com, aou@eecs.berkeley.edu,
	arnd@arndb.de, conor+dt@kernel.org, guoren@kernel.org,
	inochiama@outlook.com, krzk+dt@kernel.org, palmer@dabbelt.com,
	paul.walmsley@sifive.com, robh@kernel.org, tglx@linutronix.de,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-riscv@lists.infradead.org, chao.wei@sophgo.com,
	xiaoguang.xing@sophgo.com, fengchun.li@sophgo.com
Subject: Re: [PATCH v4 2/3] irqchip: Add the Sophgo SG2042 MSI interrupt controller
Date: Wed, 26 Feb 2025 09:37:44 +0800	[thread overview]
Message-ID: <PN0PR01MB9166295EEDDDD734F00BF4A1FEC22@PN0PR01MB9166.INDPRD01.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <nmr5qzvxxw7psymykjsaivmamt3icj6jqx6qmneofsnp33faf5@p7z6kqumfljn>


On 2025/2/21 14:35, Inochi Amaoto wrote:
[......]
>> +static int sg2042_msi_init_domains(struct sg2042_msi_chipdata *data,
>> +				   struct device *dev)
>> +{
>> +	struct fwnode_handle *fwnode = dev_fwnode(dev);
>> +	struct irq_domain *plic_domain, *middle_domain;
>> +	struct fwnode_handle *plic_node;
>> +
>> +	plic_node = fwnode_find_reference(fwnode, "msi-ranges", 0);
>> +	if (IS_ERR(plic_node)) {
>> +		pr_err("Failed to find the PLIC node!\n");
>> +		return PTR_ERR(plic_node);
>> +	}
> I think plic_node is just the args.fwnode in the sg2042_msi_probe.
> Just reuse it. No need to parse this again.
>
> Otherwise, It looks good to me. With this fix:
>
> Reviewed-by: Inochi Amaoto <inochiama@gmail.com>

Thanks, I will fix this.

Regards,

Chen

[......]



  reply	other threads:[~2025-02-26  1:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-21  5:49 [PATCH v4 0/3] irqchip: Add Sophgo SG2042 MSI controller Chen Wang
2025-02-21  5:49 ` [PATCH v4 1/3] dt-bindings: interrupt-controller: Add Sophgo SG2042 MSI Chen Wang
2025-02-21 23:47   ` Rob Herring (Arm)
2025-02-21  5:50 ` [PATCH v4 2/3] irqchip: Add the Sophgo SG2042 MSI interrupt controller Chen Wang
2025-02-21  6:35   ` Inochi Amaoto
2025-02-26  1:37     ` Chen Wang [this message]
2025-02-21  5:50 ` [PATCH v4 3/3] riscv: sophgo: dts: add msi controller for SG2042 Chen Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PN0PR01MB9166295EEDDDD734F00BF4A1FEC22@PN0PR01MB9166.INDPRD01.PROD.OUTLOOK.COM \
    --to=unicorn_wang@outlook.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=arnd@arndb.de \
    --cc=chao.wei@sophgo.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=fengchun.li@sophgo.com \
    --cc=guoren@kernel.org \
    --cc=inochiama@gmail.com \
    --cc=inochiama@outlook.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=unicornxw@gmail.com \
    --cc=xiaoguang.xing@sophgo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®