From: Aditya Garg <gargaditya08@live.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "castet.matthieu@free.fr" <castet.matthieu@free.fr>,
"stf_xl@wp.pl" <stf_xl@wp.pl>, "b-liu@ti.com" <b-liu@ti.com>,
"johan@kernel.org" <johan@kernel.org>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>,
"valentina.manea.m@gmail.com" <valentina.manea.m@gmail.com>,
"shuah@kernel.org" <shuah@kernel.org>,
"i@zenithal.me" <i@zenithal.me>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] usb: replace strcpy() with strscpy()
Date: Fri, 28 Feb 2025 17:09:36 +0000 [thread overview]
Message-ID: <PN0PR01MB958840C7836018AB49819981B8CC2@PN0PR01MB9588.INDPRD01.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <2025022833-unawake-barricade-7bb8@gregkh>
> On 28 Feb 2025, at 10:33 PM, gregkh@linuxfoundation.org wrote:
>
> On Fri, Feb 28, 2025 at 03:07:03PM +0000, Aditya Garg wrote:
>> From: Aditya Garg <gargaditya08@live.com>
>>
>> The strcpy() function has been deprecated and replaced with strscpy().
>> This patch shall replace it in the whole USB tree.
>>
>> Link: https://github.com/KSPP/linux/issues/88
>> Signed-off-by: Aditya Garg <gargaditya08@live.com>
>
> As the two functions do different things, are you sure it is safe to
> just do a search/replace here? If so, you need to explain that in the
> changelog why this is ok, and if not, please document that as well :)
That's actually a good question. From what I can tell from the kernel docs, the only case where this can be a problem is when strcpy is returning. While I don't see any such case over here, I'll still double check if that's the case. Also, I'll wait for the kernel test bot results.
next prev parent reply other threads:[~2025-02-28 17:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 15:07 Aditya Garg
2025-02-28 17:02 ` gregkh
2025-02-28 17:09 ` Aditya Garg [this message]
2025-03-01 18:49 ` kernel test robot
2025-03-01 19:33 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PN0PR01MB958840C7836018AB49819981B8CC2@PN0PR01MB9588.INDPRD01.PROD.OUTLOOK.COM \
--to=gargaditya08@live.com \
--cc=b-liu@ti.com \
--cc=castet.matthieu@free.fr \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=i@zenithal.me \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=shuah@kernel.org \
--cc=stf_xl@wp.pl \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®