From: Aditya Garg <gargaditya08@live.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
"bentiss@kernel.org" <bentiss@kernel.org>,
Alex Henrie <alexhenrie24@gmail.com>,
"jose.exposito89@gmail.com" <jose.exposito89@gmail.com>,
"bruners@gmail.com" <bruners@gmail.com>,
"seobrien@chromium.org" <seobrien@chromium.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] HID: apple: Use common table for MacBook Pro fn mapping
Date: Wed, 19 Feb 2025 16:43:43 +0000 [thread overview]
Message-ID: <PNZPR01MB4478D643BDF2E13B9BD20F5BB8C52@PNZPR01MB4478.INDPRD01.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <AF7B572F-F5E6-45A5-9B6F-3C0F763E6E4B@live.com>
Hi Jiri
I would also like to mention that these patches were made from the for-next branch of your hid tree.
> On 19 Feb 2025, at 1:38 AM, Aditya Garg <gargaditya08@live.com> wrote:
>
> Hi Jiri
>
>> On 19 Feb 2025, at 1:29 AM, Jiri Kosina <jikos@kernel.org> wrote:
>>
>>> On Fri, 14 Feb 2025, Aditya Garg wrote:
>>>
>>> From: Aditya Garg <gargaditya08@live.com>
>>>
>>> The only difference between the fn mapping of the MacBook Pros with esc key
>>> and those without is of the presence of KEY_GRAVE in the translation table.
>>>
>>> We can easily use a flag instead of writing the whole table again to omit
>>> it from the models that have an esc key.
>>>
>>> Additionally, APPLE_IGNORE_MOUSE quirk was unused in this driver, so has
>>> been removed in this commit.
>>>
>>> Signed-off-by: Aditya Garg <gargaditya08@live.com>
>>> ---
>>
>> Why am I getting v1, [RESEND v1] and v2 in the timespan of 1 day without
>> any documentation whatsoever what are the changes between the individual
>> submission and why do we have so many of them?
>
> I'll make sure changelog is provided next time.
>
> RESEND was done because I forgot to Cc the mailing lists. Its my fault here
>
> V2: I was suggested to use switch case by a colleague later that day, so added 4/4
>
>>
>> Thanks in advance for clarification,
>>
>> --
>> Jiri Kosina
>> SUSE Labs
>
>
next prev parent reply other threads:[~2025-02-19 16:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 10:05 Aditya Garg
2025-02-14 10:06 ` [PATCH v2 2/4] HID: apple: Use common table for Magic Keyboard aluminium and 2015 " Aditya Garg
2025-02-14 10:07 ` [PATCH v2 3/4] HID: apple: simplify logic for swapping only left sided option and command keys Aditya Garg
2025-02-14 10:08 ` [PATCH v2 4/4] HID: apple: use switch case to assign devices to their respective fn mapping Aditya Garg
2025-02-18 19:59 ` [PATCH v2 1/4] HID: apple: Use common table for MacBook Pro " Jiri Kosina
2025-02-18 20:08 ` Aditya Garg
2025-02-19 16:43 ` Aditya Garg [this message]
2025-03-04 20:23 ` Jiri Kosina
2025-03-05 3:33 ` Aditya Garg
2025-03-05 4:11 ` Aditya Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PNZPR01MB4478D643BDF2E13B9BD20F5BB8C52@PNZPR01MB4478.INDPRD01.PROD.OUTLOOK.COM \
--to=gargaditya08@live.com \
--cc=alexhenrie24@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bentiss@kernel.org \
--cc=bruners@gmail.com \
--cc=jikos@kernel.org \
--cc=jose.exposito89@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seobrien@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®