mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Bouska, Zdenek" <zdenek.bouska@siemens.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
	Przemek Kitszel <przemyslaw.kitszel@intel.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	John Fastabend <john.fastabend@gmail.com>,
	Stanislav Fomichev <sdf@fomichev.me>,
	Richard Cochran <richardcochran@gmail.com>,
	Song Yoong Siang <yoong.siang.song@intel.com>,
	Lai Peter Jun Ann <jun.ann.lai@intel.com>,
	Vinicius Costa Gomes <vinicius.gomes@intel.com>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"Bezdeka, Florian" <florian.bezdeka@siemens.com>
Subject: RE: [Intel-wired-lan] [PATCH v2] igc: fix page fault in XDP TX timestamps handling
Date: Wed, 11 Mar 2026 14:51:57 +0000	[thread overview]
Message-ID: <PR3PR10MB4270AE69139227E56F4D4842EB47A@PR3PR10MB4270.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <5d2c5f84-436f-4681-ad81-9900a8563b61@molgen.mpg.de>

Dear Paul,

On 25/05/2026 11:51 Paul Menzel wrote:
> Am 25.02.26 um 10:58 schrieb Zdenek Bouska via Intel-wired-lan:
> > If an XDP application that requested TX timestamping is shutting down
> > while the link of the interface in use is still up the following kernel
> > splat is reported:
> >
> > [  883.803618] [   T1554] BUG: unable to handle page fault for address:
> ffffcfb6200fd008
> > ...
> > [  883.803650] [   T1554] Call Trace:
> > [  883.803652] [   T1554]  <TASK>
> > [  883.803654] [   T1554]  igc_ptp_tx_tstamp_event+0xdf/0x160 [igc]
> > [  883.803660] [   T1554]  igc_tsync_interrupt+0x2d5/0x300 [igc]
> > ...
> >
> > During shutdown of the TX ring the xsk_meta pointers are left behind, so
> > that the IRQ handler is trying to touch them.
> >
> > This issue is now being fixed by cleaning up the stale xsk meta data on
> > TX shutdown. TX timestamps on other queues remain unaffected.
> 
> If you have the commands to reproduce this, that'd be great to have.

The software which I used is not public yet. I will let you know when that changes.

Thank you for the review!

Best regards,
Zdenek Bouska

--
Siemens, s.r.o
Foundational Technologies

  reply	other threads:[~2026-03-11 14:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25  9:58 Zdenek Bouska
2026-02-25 10:50 ` [Intel-wired-lan] " Paul Menzel
2026-03-11 14:51   ` Bouska, Zdenek [this message]
2026-02-25 11:10 ` Florian Bezdeka
2026-03-11 10:11 ` [Intel-wired-lan] " Dahan, AvigailX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PR3PR10MB4270AE69139227E56F4D4842EB47A@PR3PR10MB4270.EURPRD10.PROD.OUTLOOK.COM \
    --to=zdenek.bouska@siemens.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=florian.bezdeka@siemens.com \
    --cc=hawk@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=john.fastabend@gmail.com \
    --cc=jun.ann.lai@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pmenzel@molgen.mpg.de \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=richardcochran@gmail.com \
    --cc=sdf@fomichev.me \
    --cc=vinicius.gomes@intel.com \
    --cc=yoong.siang.song@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®