mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kevin Chen <kevin_chen@aspeedtech.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	"robh@kernel.org" <robh@kernel.org>,
	"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"joel@jms.id.au" <joel@jms.id.au>,
	"andrew@codeconstruct.com.au" <andrew@codeconstruct.com.au>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will@kernel.org" <will@kernel.org>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"olof@lixom.net" <olof@lixom.net>,
	"quic_bjorande@quicinc.com" <quic_bjorande@quicinc.com>,
	"geert+renesas@glider.be" <geert+renesas@glider.be>,
	"dmitry.baryshkov@linaro.org" <dmitry.baryshkov@linaro.org>,
	"konradybcio@kernel.org" <konradybcio@kernel.org>,
	"neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
	"johan+linaro@kernel.org" <johan+linaro@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"soc@lists.linux.dev" <soc@lists.linux.dev>
Subject: RE: [PATCH v3 1/6] dt-bindings: interrupt-controller: Refine size/interrupt-cell usage.
Date: Wed, 18 Dec 2024 03:04:32 +0000	[thread overview]
Message-ID: <PSAPR06MB4949CF57BD69B2F7C1D141CD89052@PSAPR06MB4949.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <11ad5a97-b066-4bea-8829-50e0416cea9d@kernel.org>

Hi Krzk,

> > 1. Because size-cells is no need to use 2, modify to 1 for use.
> 
> ???
So, is it OK that I change the size-cells back to 2 include the aspeed,ast2700-intc.yaml examples and aspeed-g7.dtsi?

> 
> > 2. Add minItems to 1 for interrupts for intc1.
> 
> ???
For variable interrupt numbers, I need to fix the below warnings by minItems.
  DTC [C] arch/arm64/boot/dts/aspeed/ast2700-evb.dtb
/home/kevin/linux-mainline/arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@100: interrupts-extended: [[3, 0, 3844]] is too short
        from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml#
/home/kevin/linux-mainline/arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@110: interrupts-extended: [[3, 1, 3844]] is too short
        from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml#
/home/kevin/linux-mainline/arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@120: interrupts-extended: [[3, 2, 3844]] is too short
        from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml#
/home/kevin/linux-mainline/arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@130: interrupts-extended: [[3, 3, 3844]] is too short
        from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml#
/home/kevin/linux-mainline/arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@140: interrupts-extended: [[3, 4, 3844]] is too short
        from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml#
/home/kevin/linux-mainline/arch/arm64/boot/dts/aspeed/ast2700-evb.dtb: interrupt-controller@150: interrupts-extended: [[3, 5, 3844]] is too short
        from schema $id: http://devicetree.org/schemas/interrupt-controller/aspeed,ast2700-intc.yaml#

> 
> > 3. Add 1 interrupt of intc1 example into yaml file.
> 
> > 4. Add intc1 sub-module of uart12 as example using the intc0 and intc1.
> 
> What is all this?
> 
> BTW, there was no such patch in previous version and your changelog is silent
> about it.
Agree, I will restore the previous version.

> 
> Subject: drop all full stops. Subject never ends with full stop.
> 
> > ---
> >  .../aspeed,ast2700-intc.yaml                  | 60
> +++++++++++++++----
> >  1 file changed, 47 insertions(+), 13 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast270
> > 0-intc.yaml
> > b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast270
> > 0-intc.yaml index 55636d06a674..eadfbc45326b 100644
> > ---
> > a/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast270
> > 0-intc.yaml
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/aspeed,as
> > +++ t2700-intc.yaml
> > @@ -31,6 +31,7 @@ properties:
> >        type as defined in interrupt.txt in this directory.
> >
> >    interrupts:
> > +    minItems: 1
> 
> Nope, not explained, not constrained. Your schema is supposed to be
> constrained.
> 
> 
> >      maxItems: 6
> >      description: |
> >        Depend to which INTC0 or INTC1 used.
> > @@ -68,19 +69,52 @@ examples:
> >      #include <dt-bindings/interrupt-controller/arm-gic.h>
> >
> >      bus {
> > +      #address-cells = <2>;
> > +      #size-cells = <1>;
> > +
> > +      intc0: interrupt-controller@12100000 {
> > +        compatible = "simple-mfd";
> > +        reg = <0 0x12100000 0x4000>;
> > +        ranges = <0x0 0x0 0x0 0x12100000 0x4000>;
> >          #address-cells = <2>;
> > -        #size-cells = <2>;
> > -
> > -        interrupt-controller@12101b00 {
> > -            compatible = "aspeed,ast2700-intc-ic";
> > -            reg = <0 0x12101b00 0 0x10>;
> > -            #interrupt-cells = <2>;
> > -            interrupt-controller;
> > -            interrupts = <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 195 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>,
> > -                         <GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>;
> 
> 
> I don't understand what is all this.
> 
> > +        #size-cells = <1>;
> > +
> > +        intc0_11: interrupt-controller@1b00 {
> > +          compatible = "aspeed,ast2700-intc-ic";
> > +          reg = <0 0x12101b00 0x10>;
> > +          #interrupt-cells = <2>;
> > +          interrupt-controller;
> > +          interrupts = <GIC_SPI 192 (GIC_CPU_MASK_SIMPLE(4) |
> IRQ_TYPE_LEVEL_HIGH)>,
> > +                       <GIC_SPI 193 (GIC_CPU_MASK_SIMPLE(4) |
> IRQ_TYPE_LEVEL_HIGH)>,
> > +                       <GIC_SPI 194 (GIC_CPU_MASK_SIMPLE(4) |
> IRQ_TYPE_LEVEL_HIGH)>,
> > +                       <GIC_SPI 195 (GIC_CPU_MASK_SIMPLE(4) |
> IRQ_TYPE_LEVEL_HIGH)>,
> > +                       <GIC_SPI 196 (GIC_CPU_MASK_SIMPLE(4) |
> IRQ_TYPE_LEVEL_HIGH)>,
> > +                       <GIC_SPI 197 (GIC_CPU_MASK_SIMPLE(4) |
> > + IRQ_TYPE_LEVEL_HIGH)>;
> >          };
> > +      };
> > +
> > +      intc1: interrupt-controller@14c18000 {
> > +        compatible = "simple-mfd";
> > +        reg = <0 0x14c18000 0x400>;
> > +        ranges = <0x0 0x0 0x0 0x14c18000 0x400>;
> > +        #address-cells = <2>;
> > +        #size-cells = <1>;
> > +
> > +        intc1_4: interrupt-controller@140 {
> > +          compatible = "aspeed,ast2700-intc-ic";
> > +          reg = <0x0 0x140 0x10>;
> > +          #interrupt-cells = <2>;
> > +          interrupt-controller;
> > +          interrupts-extended = <&intc0_11 4
> (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>;
> > +        };
> > +      };
> > +
> > +      uart12: serial@14c33b00 {
> > +        compatible = "ns16550a";
> > +        reg = <0x0 0x14c33b00 0x100>;
> > +        interrupts-extended = <&intc1_4 18 (GIC_CPU_MASK_SIMPLE(4)
> | IRQ_TYPE_LEVEL_HIGH)>;
> > +        reg-shift = <2>;
> > +        reg-io-width = <4>;
> > +        no-loopback-test;
> > +      };
> 
> And above is not related at all. Don't add entirely unrelated changes. Drop.
> 
> 
> Best regards,
> Krzysztof

Best Regards,
Kevin. Chen

  reply	other threads:[~2024-12-18  3:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-12 15:52 [PATCH v3 0/6] Introduce ASPEED AST27XX BMC SoC Kevin Chen
2024-12-12 15:52 ` [PATCH v3 1/6] dt-bindings: arm: aspeed: Add ASPEED AST27XX SoC Kevin Chen
2024-12-13  7:56   ` Krzysztof Kozlowski
2024-12-12 15:52 ` [PATCH v3 1/6] dt-bindings: interrupt-controller: Refine size/interrupt-cell usage Kevin Chen
2024-12-13  7:58   ` Krzysztof Kozlowski
2024-12-18  3:04     ` Kevin Chen [this message]
2024-12-18  8:07       ` Krzysztof Kozlowski
2024-12-13  9:10   ` Krzysztof Kozlowski
2024-12-16  3:50     ` Kevin Chen
2024-12-12 15:52 ` [PATCH v3 2/6] dt-bindings: arm: aspeed: Add ASPEED AST27XX SoC Kevin Chen
2024-12-13  7:59   ` Krzysztof Kozlowski
2024-12-13  8:03     ` Krzysztof Kozlowski
2024-12-18  2:55       ` Kevin Chen
2024-12-18  8:11         ` Krzysztof Kozlowski
2024-12-12 15:52 ` [PATCH v3 2/6] dt-bindings: interrupt-controller: Fix the size-cells in ast2700-intc Kevin Chen
2024-12-13  7:59   ` Krzysztof Kozlowski
2024-12-12 15:52 ` [PATCH v3 3/6] arm64: aspeed: Add support for ASPEED AST27XX BMC SoC Kevin Chen
2024-12-12 15:52 ` [PATCH v3 4/6] arm64: dts: aspeed: Add initial AST27XX device tree Kevin Chen
2024-12-13  8:01   ` Krzysztof Kozlowski
2024-12-18  2:50     ` Kevin Chen
2024-12-12 15:52 ` [PATCH v3 5/6] arm64: dts: aspeed: Add initial AST2700 EVB " Kevin Chen
2024-12-13  8:03   ` Krzysztof Kozlowski
2024-12-16  3:58     ` Kevin Chen
2024-12-12 15:52 ` [PATCH v3 6/6] arm64: defconfig: Add ASPEED AST2700 family support Kevin Chen
2024-12-13  5:07 ` [PATCH v3 0/6] Introduce ASPEED AST27XX BMC SoC Andrew Jeffery
2024-12-16  3:34   ` Kevin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PSAPR06MB4949CF57BD69B2F7C1D141CD89052@PSAPR06MB4949.apcprd06.prod.outlook.com \
    --to=kevin_chen@aspeedtech.com \
    --cc=andrew@codeconstruct.com.au \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=geert+renesas@glider.be \
    --cc=joel@jms.id.au \
    --cc=johan+linaro@kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=olof@lixom.net \
    --cc=quic_bjorande@quicinc.com \
    --cc=robh@kernel.org \
    --cc=soc@lists.linux.dev \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®