mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: bert hubert <ahu@ds9a.nl>
Cc: <lartc@mailman.ds9a.nl>, <linux-kernel@vger.kernel.org>,
	<kuznet@ms2.inr.ac.ru>, <netdev@oss.sgi.com>
Subject: Re: further CBQ/tc documentation ds9a.nl/lartc/manpages
Date: Sat, 8 Dec 2001 15:43:05 -0500 (EST)	[thread overview]
Message-ID: <Pine.GSO.4.30.0112081513430.4764-100000@shell.cyberus.ca> (raw)
In-Reply-To: <20011208205541.A15565@outpost.ds9a.nl>



For starters, i think you need a defintions sections. Look at:
http://www.ietf.org/internet-drafts/draft-ietf-diffserv-model-06.txt

(eg what is a shaper etc and how trhings are placed together). At least
that will ensure that you dont sday things like "Prio cant shape".

It is a good model but may be insufficient given Linux TCs
capabilities. Email me when unsure.

Some other things:
- In your comment "Do not confuse this classless simple qdisc with the
classful PRIO one!". This is misleading:
the default 3 band FIFO queue is conceptually the same as the
default prio qdisc (the priomaps are identical). 3 bands; same
prioritization schemes.
- You really need to fix ingress section:
 it works for both forwarding and packets coming in to local sockets.
More importantly, It takes advantages of _all_ filter schemes
available for TC as well as the policing functionality (which sadly seemed
to have been replicated by someone in netfilter, wrongly if i may add ;->).
- You keep saying "reodering" -- dont know what that means. Reordering is
generally considered a Bad Thing(tm).

- your description of the "peakrate" (same in TBF as well as policing)

Well captured. It took ages to get this into peoples heads. This also
applies to CBQ.

- your description of "MTU"
Not very good description:
This is just what it literally says; maximum transmit unit;
A packet larger than this will be dropped. Default is 2K. For ethernet,
MTUs of 1500 bytes, this is fine; however, you should put a cautionary
statement here in regards to people having MTUs smaller than 2K (example
the lo device); they might find that all their packets greater than 2K
being dropped.


More later if dont get distracted.

cheers,
jamal



  reply	other threads:[~2001-12-08 20:47 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-12-01  0:33 Finally, CBQ nearly completely documented bert hubert
2001-12-03  2:00 ` CBQ and all other qdiscs now REALLY completely documented (almost!) bert hubert
2001-12-03  2:26   ` [LARTC] " Jim Fleming
2001-12-08 19:20   ` jamal
2001-12-08 19:55     ` further CBQ/tc documentation ds9a.nl/lartc/manpages bert hubert
2001-12-08 20:43       ` jamal [this message]
2001-12-08 23:23     ` CBQ and all other qdiscs now REALLY completely documented (almost!) bert hubert
2001-12-09  1:14       ` jamal
2001-12-09  1:30         ` bert hubert
2001-12-09  2:10           ` jamal
2001-12-09 18:14         ` CBQ and all other qdiscs now REALLY completely documented kuznet
2001-12-09 18:18           ` bert hubert
2001-12-09 21:45           ` jamal
2001-12-09 21:53             ` bert hubert
2001-12-09 22:07               ` jamal
2001-12-09 22:13                 ` bert hubert
2001-12-10  0:58                   ` jamal
2001-12-10 17:04             ` kuznet
2001-12-10  0:41           ` CBQ MANPAGE: I hear the theme of '2001, A Space Odyssey' bert hubert
2001-12-10  1:04             ` jamal
2001-12-10  1:12               ` bert hubert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.GSO.4.30.0112081513430.4764-100000@shell.cyberus.ca \
    --to=hadi@cyberus.ca \
    --cc=ahu@ds9a.nl \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=lartc@mailman.ds9a.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®