mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: jamal <hadi@cyberus.ca>
To: Mark Mielke <mark@mark.mielke.cc>
Cc: "David S. Miller" <davem@redhat.com>, <ltd@cisco.com>,
	<greearb@candelatech.com>, <cfriesen@nortelnetworks.com>,
	<linux-kernel@vger.kernel.org>, <netdev@oss.sgi.com>
Subject: Re: RFC: per-socket statistics on received/dropped packets
Date: Mon, 10 Jun 2002 10:45:31 -0400 (EDT)	[thread overview]
Message-ID: <Pine.GSO.4.30.0206101033450.22559-100000@shell.cyberus.ca> (raw)
In-Reply-To: <20020610095702.A27037@mark.mielke.cc>



On Mon, 10 Jun 2002, Mark Mielke wrote:

> On Mon, Jun 10, 2002 at 08:24:44AM -0400, jamal wrote:
> > I think i would agree with Dave for it to be an external patch. You
> > really only need this during debugging. I had a similar patch when
> > debugging NAPI about a year ago. I didnt find it that useful after
> > a while because i could deduce the losses from SNMP/netstat output.
>
> In your case you found that you could solve it once by debugging the
> application.
>
> This doesn't mean that other applications would not be better at
> determining the code path to use at execution time.
>
> Just because eth1 is behaving perfectly (i.e. low overall dropped UDP
> packets, or low TCP/IP retransmission) does not mean that a specific
> socket currently on eth1 heading to China should assume that it can
> take the 'average' observation as adequate for observing the specific
> socket.
>
> There *are* applications that would benefit from making this decision
> at run time on a socket-by-socket basis. It is not a common requirement
> for most desktop users, but it remains a valid requirement.
>

I am confused as to which application needs this, do you have one in mind?
AFAIK, UDP/RTP type apps already know how to determine packet loss
on a per flow basis.

> Providing it as a patch, can have the effect that it becomes more trouble
> than it is worth to grant other people access to the feature, especially
> from a corporate environment that has signed off on being able to release
> patches made to Linux back to the Linux source tree.
>

You may be confusing technical merit to mean the same thing as corporate
donation. In Linux its the later that counts.

> Seems somewhat of a loss...

Your mileage may vary. Consider this - you have the opp to at least
make the patch available. Imagine trying to convince windriver.

cheers,
jamal

>

> mark
>
> --
> mark@mielke.cc/markm@ncf.ca/markm@nortelnetworks.com __________________________
> .  .  _  ._  . .   .__    .  . ._. .__ .   . . .__  | Neighbourhood Coder
> |\/| |_| |_| |/    |_     |\/|  |  |_  |   |/  |_   |
> |  | | | | \ | \   |__ .  |  | .|. |__ |__ | \ |__  | Ottawa, Ontario, Canada
>
>   One ring to rule them all, one ring to find them, one ring to bring them all
>                        and in the darkness bind them...
>
>                            http://mark.mielke.cc/
>


  reply	other threads:[~2002-06-10 14:51 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-06 19:37 Chris Friesen
2002-06-07  3:21 ` David S. Miller
2002-06-07 15:34   ` Chris Friesen
2002-06-07 22:15   ` Ben Greear
2002-06-08 21:05     ` Mark Mielke
2002-06-08 23:04       ` David S. Miller
2002-06-09  0:13         ` Ben Greear
2002-06-09  0:51           ` David S. Miller
2002-06-09 18:23             ` Ben Greear
2002-06-10  4:34               ` David S. Miller
2002-06-10  5:55                 ` Mark Mielke
2002-06-10  6:08                 ` Ben Greear
2002-06-10 12:03                 ` Lincoln Dale
2002-06-10 12:18                   ` David S. Miller
2002-06-10 12:24                     ` jamal
2002-06-10 13:57                       ` Mark Mielke
2002-06-10 14:45                         ` jamal [this message]
2002-06-10 14:56                           ` jamal
2002-06-10 19:28                           ` Chris Friesen
2002-06-10 18:44                     ` David Ford
2002-06-10 18:50                       ` Thunder from the hill
2002-06-10 19:02                         ` David Ford
2002-06-11 22:41                 ` Bill Davidsen
2002-06-12  3:41                   ` David S. Miller
2002-06-12  3:57                     ` Richard Guy Briggs
2002-06-12  5:20                       ` Mark Mielke
2002-06-12  6:08                         ` Pekka Savola
2002-06-12  6:26                           ` Ben Greear
2002-06-12  6:32                             ` Pekka Savola
2002-06-12  6:49                               ` Ben Greear
2002-06-12 12:11                             ` Horst von Brand
2002-06-12 12:28                               ` Lincoln Dale
2002-06-12 12:33                                 ` jamal
2002-06-12 12:44                                   ` Lincoln Dale
2002-06-12 13:00                                     ` jamal
2002-06-12 14:53                                       ` Mark Mielke
2002-06-12 15:57                                         ` jamal
2002-06-12 17:00                                         ` Horst von Brand
2002-06-14  0:24                                       ` Lincoln Dale
2002-06-14 15:51                                         ` Stephen Hemminger
2002-06-14 18:09                                           ` Ben Greear
2002-06-12 14:52                                 ` john slee
2002-06-12 14:55                                   ` Mark Mielke
2002-06-13  2:52                                   ` Lincoln Dale
2002-06-13 19:53                                     ` Horst von Brand
2002-06-13  7:21                                 ` David Schwartz
2002-06-13  8:44                                   ` Lincoln Dale
2002-06-13 10:10                                     ` David Schwartz
2002-06-23  2:03                                 ` Alan Cox
2002-06-23  2:05                                   ` Lincoln Dale
2002-06-12  9:18                         ` Sean Hunter
2002-06-09 14:47       ` Pekka Pietikäinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.GSO.4.30.0206101033450.22559-100000@shell.cyberus.ca \
    --to=hadi@cyberus.ca \
    --cc=cfriesen@nortelnetworks.com \
    --cc=davem@redhat.com \
    --cc=greearb@candelatech.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ltd@cisco.com \
    --cc=mark@mark.mielke.cc \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®