From: "Noah J. Misch" <noah@caltech.edu>
To: torvalds@osdl.org, linux-kernel@vger.kernel.org
Cc: acme@conectiva.com.br, linux-net@vger.kernel.org
Subject: [PATCH] Make linux/init.h include linux/compiler.h
Date: Thu, 9 Oct 2003 22:57:44 -0700 (PDT) [thread overview]
Message-ID: <Pine.GSO.4.58.0310092219040.25392@sue> (raw)
Greetings Linus,
Since __exit and __exit_call from init.h use __attribute_used__ from compiler.h
and are two of the most common macros for which files include init.h, init.h
should include compiler.h.
I think this patch would be appropriate anyway, but note the patch "Make
net/ipx/ipx_proc.c compile w/o CONFIG_PROC_FS", which I have CC-ed to all
recipients of this message, and that depends upon this patch. Without this
patch, ipx_proc.c would need to include both init.h and compiler.h, the latter
for no other reason than to support init.h. I don't think that's good.
Thanks,
Noah
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1341 -> 1.1342
# include/linux/init.h 1.27 -> 1.28
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/10/10 noah@caltech.edu 1.1342
# Make linux/init.h include linux/compiler.h. The __exit and __exit_call
# macros, among others, need the __attribute_used__ macro defined there.
# --------------------------------------------
#
diff -Nru a/include/linux/init.h b/include/linux/init.h
--- a/include/linux/init.h Fri Oct 10 00:58:50 2003
+++ b/include/linux/init.h Fri Oct 10 00:58:50 2003
@@ -2,6 +2,7 @@
#define _LINUX_INIT_H
#include <linux/config.h>
+#include <linux/compiler.h>
/* These macros are used to mark some functions or
* initialized data (doesn't apply to uninitialized data)
reply other threads:[~2003-10-10 5:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.58.0310092219040.25392@sue \
--to=noah@caltech.edu \
--cc=acme@conectiva.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®