From: "Noah J. Misch" <noah@caltech.edu>
To: dwmw2@redhat.com
Cc: mtd@infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Remove needless and non-portable include in mtd
Date: Sun, 19 Oct 2003 21:36:15 -0700 (PDT) [thread overview]
Message-ID: <Pine.GSO.4.58.0310171454050.13905@blinky> (raw)
Hello David,
The #include <asm/setup.h> in drivers/mtd/cmdlinepart.c does not appear to
provide any definition this file uses, and it quickly breaks builds on
architectures that lack such a header, including ia64 and sparc.
This applies to your CVS and linux-2.5 BK as of 0700 UTC 10/20/2003 and passes
an allyesconfig on (with unrelated exceptions) i386, ia64, and sparc. I do not
have the hardware to test it further, but I think the change is straightforward.
Please let me know if you need further information.
I will probably send you at least one more MTD compatibility patch.
Thanks,
Noah
# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
# ChangeSet 1.1369 -> 1.1370
# drivers/mtd/cmdlinepart.c 1.5 -> 1.6
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/10/16 noah@caltech.edu 1.1370
# Remove needless include of asm/setup.h in drivers/mtd/cmdlinepart.c. This
# was breaking compilation on architectures that lack such a header.
# --------------------------------------------
#
diff -Nru a/drivers/mtd/cmdlinepart.c b/drivers/mtd/cmdlinepart.c
--- a/drivers/mtd/cmdlinepart.c Fri Oct 17 13:40:56 2003
+++ b/drivers/mtd/cmdlinepart.c Fri Oct 17 13:40:56 2003
@@ -28,7 +28,6 @@
#include <linux/mtd/mtd.h>
#include <linux/mtd/partitions.h>
-#include <asm/setup.h>
#include <linux/bootmem.h>
/* error message prefix */
next reply other threads:[~2003-10-20 4:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-20 4:36 Noah J. Misch [this message]
2003-10-20 14:58 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.58.0310171454050.13905@blinky \
--to=noah@caltech.edu \
--cc=dwmw2@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtd@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®