From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Urban Widmark <Urban.Widmark@enlight.net>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
JohnNewbigin <jn@it.swin.edu.au>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: smb_ops_unix warning (was: Re: Linux 2.4.25-rc2)
Date: Fri, 13 Feb 2004 10:13:07 +0100 (MET) [thread overview]
Message-ID: <Pine.GSO.4.58.0402131012330.23784@waterleaf.sonytel.be> (raw)
In-Reply-To: <Pine.LNX.4.44.0402121758290.14391-100000@cola.local>
On Thu, 12 Feb 2004, Urban Widmark wrote:
> On Thu, 12 Feb 2004, Geert Uytterhoeven wrote:
> > On Wed, 11 Feb 2004, Marcelo Tosatti wrote:
> > > Here goes -rc2, with small number of fixes and corrections.
> >
> > This patch adds a missing include (fortunately it was included in some other
> > include, but its' not clean for files that check CONFIG_* flags) and kills a
> > compiler warning (introduced in -rc1, IIRC) if CONFIG_SMB_UNIX is not set.
>
> Ah, thanks.
>
>
> > Alternatively, perhaps the code can be reshuffled a bit to avoid too many
> > ifdefs?
>
> Code below builds cleanly for me either way, but I have not tested it yet.
> Will do that later.
>
> The config could also be removed, but I like that 2.4 users can keep the
> previous 2.4 behaviour if they want to.
I can confirm it has the same result: no more compiler warnings.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2004-02-13 9:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-11 19:31 Linux 2.4.25-rc2 Marcelo Tosatti
2004-02-12 12:48 ` smb_ops_unix warning (was: Re: Linux 2.4.25-rc2) Geert Uytterhoeven
2004-02-12 17:16 ` Urban Widmark
2004-02-13 9:13 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.GSO.4.58.0402131012330.23784@waterleaf.sonytel.be \
--to=geert@linux-m68k.org \
--cc=Urban.Widmark@enlight.net \
--cc=jn@it.swin.edu.au \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®