mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>,
	Jes Sorensen <jes@trained-monkey.org>,
	Linux/m68k <linux-m68k@lists.linux-m68k.org>
Subject: Re: [PATCH] Clean up asm/pgalloc.h include (m68k)
Date: Mon, 19 Apr 2004 18:39:23 +0200 (MEST)	[thread overview]
Message-ID: <Pine.GSO.4.58.0404191835140.3430@waterleaf.sonytel.be> (raw)
In-Reply-To: <20040419173046.E29446@flint.arm.linux.org.uk>

On Mon, 19 Apr 2004, Russell King wrote:
> On Mon, Apr 19, 2004 at 06:18:41PM +0200, Geert Uytterhoeven wrote:
> > Do you really need <asm/pgalloc.h> in include/asm-generic/tlb.h?
>
> Yes it does - tlb.h uses check_pgt_cache().  Also, architecture code
> makes use of __pmd_free_tlb and __pte_free_tlb, both of which make
> use of code from asm/pgalloc.h.
>
> Not including asm/pgalloc.h into asm/tlb.h or asm-generic/tlb.h means
> that all the generic files have to know that asm/tlb.h needs asm/pgalloc.h,
> and they also then need to know that asm/pgalloc.h needs asm/pgtable.h,
> and asm/pgtable.h needs ...
>
> Is there a reason why:
>
> static inline void __pte_free_tlb(struct mmu_gather *tlb, struct page *page)
> {
>         tlb_remove_page(tlb, page);
> }
>
> can't be like x86 and others in their pgalloc.h:

(because we more like static inline functions than macros?)

> #define __pte_free_tlb(tlb,pte) tlb_remove_page((tlb),(pte))
>
> (for consistency sake if nothing else) ?

Ah, I didn't look at ia32. That solution is fine for me!
Here's the additional patch:

--- linux-m68k-2.6.6-rc1-rmk/include/asm-m68k/sun3_pgalloc.h	2004-04-04 11:08:37.000000000 +0200
+++ linux-m68k-2.6.6-rc1-geert/include/asm-m68k/sun3_pgalloc.h	2004-04-19 18:37:37.000000000 +0200
@@ -31,10 +31,7 @@
         __free_page(page);
 }

-static inline void __pte_free_tlb(struct mmu_gather *tlb, struct page *page)
-{
-	tlb_remove_page(tlb, page);
-}
+#define __pte_free_tlb(tlb,pte) tlb_remove_page((tlb),(pte))

 static inline pte_t *pte_alloc_one_kernel(struct mm_struct *mm,
 					  unsigned long address)

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

  reply	other threads:[~2004-04-19 16:39 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-18 22:17 [PATCH 1/2] Clean up asm/pgalloc.h include Russell King
2004-04-18 22:23 ` [PATCH 2/2] " Russell King
2004-04-18 22:48   ` [PATCH 3/2] " Russell King
2004-04-19 13:20   ` [PATCH] Clean up asm/pgalloc.h include (alpha) Russell King
2004-04-19 20:55     ` Ivan Kokshaysky
2004-04-19 13:20   ` [PATCH] Clean up asm/pgalloc.h include (arm26) Russell King
2004-04-19 13:20   ` [PATCH] Clean up asm/pgalloc.h include (cris) Russell King
2004-04-19 13:21   ` [PATCH] Clean up asm/pgalloc.h include (H8300) Russell King
2004-04-19 13:21   ` [PATCH] Clean up asm/pgalloc.h include (ia64) Russell King
2004-04-19 20:56     ` Alex Williamson
2004-04-19 13:21   ` [PATCH] Clean up asm/pgalloc.h include (m68k) Russell King
2004-04-19 16:18     ` Geert Uytterhoeven
2004-04-19 16:30       ` Russell King
2004-04-19 16:39         ` Geert Uytterhoeven [this message]
2004-04-19 16:38       ` Russell King
2004-04-19 13:21   ` [PATCH] Clean up asm/pgalloc.h include (m68knommu) Russell King
2004-04-19 13:21   ` [PATCH] Clean up asm/pgalloc.h include (mips) Russell King
2004-04-19 16:36     ` Ralf Baechle
2004-04-19 13:21   ` [PATCH] Clean up asm/pgalloc.h include (parisc) Russell King
2004-04-19 13:22   ` [PATCH] Clean up asm/pgalloc.h include (ppc) Russell King
2004-04-29 22:08     ` Tom Rini
2004-04-19 13:22   ` [PATCH] Clean up asm/pgalloc.h include (ppc64) Russell King
2004-04-19 13:22   ` [PATCH] Clean up asm/pgalloc.h include (s390) Russell King
2004-04-19 13:22   ` [PATCH] Clean up asm/pgalloc.h include (sh) Russell King
2004-04-20 14:46     ` Paul Mundt
2004-04-20 16:01       ` Hugh Dickins
2004-04-20 16:19         ` Paul Mundt
2004-04-19 13:22   ` [PATCH] Clean up asm/pgalloc.h include (sparc) Russell King
2004-04-19 13:23   ` [PATCH] Clean up asm/pgalloc.h include (sparc64) Russell King
2004-04-19 13:23   ` [PATCH] Clean up asm/pgalloc.h include (v850) Russell King
2004-04-19 13:23   ` [PATCH] Clean up asm/pgalloc.h include (x86_64) Russell King
2004-04-19 14:03     ` [discuss] " Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.GSO.4.58.0404191835140.3430@waterleaf.sonytel.be \
    --to=geert@linux-m68k.org \
    --cc=jes@trained-monkey.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=rmk+lkml@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®