mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andre Hedrick <andre@linux-ide.org>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: Andries.Brouwer@cwi.nl, axboe@suse.de, alan@lxorguk.ukuu.org.uk,
	linux-kernel@vger.kernel.org, p_gortmaker@yahoo.com
Subject: Re: [PATCH] off-by-1 error in ide-probe (2.4.x)
Date: Sun, 18 Mar 2001 18:23:11 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.10.10103181815490.17416-100000@master.linux-ide.org> (raw)
In-Reply-To: <Pine.LNX.4.31.0103181723160.2981-100000@penguin.transmeta.com>

On Sun, 18 Mar 2001, Linus Torvalds wrote:

> 
> 
> On Mon, 19 Mar 2001 Andries.Brouwer@cwi.nl wrote:
> >
> >     Agreed. That would be a trivially easy bug in the firmware, limiting to
> >     255 sectors seems safer.
> >
> >             Linus
> >
> > Yes, possibly.
> > I checked old standards, and see that "0 means 256 as a sector count"
> > is already in ATA-1.
> 
> Yes. But we could have some silly bug in the Linux drivers too, if some
> part of the driver reads back the sector count and doesn't do the 0==256
> conversion. So let's not blame the disk quite yet. Although it would be
> interesting to hear if the problem only happens for a specific disk or
> manufacturer...

LT,

This is why I want to standardize the data-phase rules, but we have agreed
to postpone for 2.5.  Since the glue for the main loops is spread like hot
butter, it covers up a lot of issues and threads get messy.  I had all but
given up on chasing them down and then resolved to start from scratch.


Andre Hedrick
Linux ATA Development


  reply	other threads:[~2001-03-19  3:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-03-19  0:18 Andries.Brouwer
2001-03-19  1:24 ` Linus Torvalds
2001-03-19  2:23   ` Andre Hedrick [this message]
  -- strict thread matches above, loose matches on Subject: below --
2001-03-18  9:19 Paul Gortmaker
2001-03-18 21:35 ` Jens Axboe
2001-03-18 23:27   ` Linus Torvalds
2001-03-18 23:32     ` Andre Hedrick
2001-03-22  9:26   ` Paul Gortmaker
2001-03-22 13:32     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.10.10103181815490.17416-100000@master.linux-ide.org \
    --to=andre@linux-ide.org \
    --cc=Andries.Brouwer@cwi.nl \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p_gortmaker@yahoo.com \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®