From: Andre Hedrick <andre@linux-ide.org>
To: Jens Axboe <axboe@kernel.org>
Cc: Mark Hahn <hahn@coffee.psychology.mcmaster.ca>,
alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org
Subject: Re: [patch]: ide dma timeout retry in pio
Date: Mon, 28 May 2001 17:09:20 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.10.10105281701070.414-100000@master.linux-ide.org> (raw)
In-Reply-To: <20010529002600.B26871@suse.de>
On Tue, 29 May 2001, Jens Axboe wrote:
> This is bull shit. If IDE didn't muck around with the request so much in
> the first place, the info could always be trusted. Even so, we have the
> hard_* numbers to go by. So this argument does not hold.
Maybe if you looked at the new code model as a whole you would see that
the request-forking is gone. The object is to preserve a copy of the io
instructions out to the registers to not have to repeat the do_request
call unless it is a do or die thing. Also it is good to carry a copy of
the local request even if it is never used. Also are you resetting the
pointer (back to the geginning) on rq->buffer on the retry?
You first flush the DMA engine and issue a device soft reset not using the
current drive reset, is presevers the hwgroup->busy state and allows the
request to be retried without reinserting.
> > As I recall, there is a way to reinsert the faulted request, but that
>
> Again, look at the patch. The request is never off the list, so there is
> never a reason to reinsert. hwgroup->busy is cleared (and, again for
> good measure, hwgroup->rq), so ide_do_request/start_request will get the
> same request that we just handled.
I will have to poke in a few flags to verify this but if you say so.
> > means the request_struct needs fault counter. If it is truly a DMA error
>
> ->errors, it's already there.
Wrong location to poke and by that time it requires a full retry.
The new code would have had the task structs filled with the error.
> > because of re-seeks then the timeout value for that request must be
> > expanded.
>
> Yep
In some cases yes, but it would be better if I had a standard counter that
meant something. Also changing the jiffie counter in ide_delay_50ms to a
mdelay may have done more harm than good.
Andre Hedrick
Linux ATA Development
ASL Kernel Development
-----------------------------------------------------------------------------
ASL, Inc. Toll free: 1-877-ASL-3535
1757 Houret Court Fax: 1-408-941-2071
Milpitas, CA 95035 Web: www.aslab.com
next prev parent reply other threads:[~2001-05-29 0:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-28 18:34 Jens Axboe
2001-05-28 19:39 ` Mark Hahn
2001-05-28 20:13 ` Christopher B. Liebman
2001-05-28 20:37 ` Jens Axboe
2001-05-28 22:15 ` Andre Hedrick
2001-05-28 22:26 ` Jens Axboe
2001-05-29 0:09 ` Andre Hedrick [this message]
2001-05-29 0:30 ` Jens Axboe
2001-05-28 21:12 ` Alan Cox
2001-05-28 22:11 ` James Turinsky
2001-05-29 6:18 ` Larry McVoy
2001-05-28 22:20 ` Alan Cox
2001-05-28 22:56 ` Meelis Roos
2001-05-29 7:11 ` Larry McVoy
2001-05-30 21:09 Diefenbaugh, Paul S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.10.10105281701070.414-100000@master.linux-ide.org \
--to=andre@linux-ide.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=axboe@kernel.org \
--cc=hahn@coffee.psychology.mcmaster.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®