From: Andre Hedrick <andre@linux-ide.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Alex Davis <alex14641@yahoo.com>,
miquels@cistron.nl, linux-kernel@vger.kernel.org
Subject: Re: Possible bug and question about ide_notify_reboot in 2.4.19
Date: Sat, 14 Sep 2002 13:57:58 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.10.10209141342090.6925-100000@master.linux-ide.org> (raw)
In-Reply-To: <1032031927.13636.1.camel@irongate.swansea.linux.org.uk>
Hi Alex,
We (T13 Standards) only recently required (shall) all non-packet device to
support flush cache. No where does it state that a device supporting PM
for a standby (shall), the key word here is "shall", issue a flush-cache.
Does the early IBM laptop drive ring a bell?
IBM set an erratium about flush cache and spindown/power down, where it is
the "host driver" is responsible for the data.
So regardless of what you want, and what hardware you have, there is
hardware which doesn't do it properly.
So if yours gets it correct, great, dance for joy.
I will not break support for older hardware, on a whim.
You said you can make a patch, please do so and apply it to your tree.
One thing you will figure out is I am absolutely retentive to the SPEC,
and careful to not break older version of the standard, even retired
versions.
Now, if you want the option, submit the patch for review. For two or
three days there has been no patch to test.
To be absolutely honest, I really do not like to give options in the
kernel-config build which can cause backwards compatablity problems.
The only what I would consider it is to perform a revision check on
major/minor against the devices present and should any device violate,
forcablely OOPS the kernel into a deadlock crash before filesystems can be
mounted.
Cheers,
Andre Hedrick
LAD Storage Consulting Group
On 14 Sep 2002, Alan Cox wrote:
> On Sat, 2002-09-14 at 19:28, Alex Davis wrote:
> > >Putting the drive in stand-by mode has the side effect of flushing
> > >the cache.
> > Maxtor's tech support says this is NOT true.
>
> Hint 1. Other people make disks too
> Hint 2. The guys who did the code include a member of the standards
> committee.
>
>
> > Ok how about this: I'm current testing some patches against
> > ide.c and friends. Why don't I just add ( and document ) a
> > define called NO_STANDBY_ON_SHUTDOWN which would live in
> > ide.c. By default it would not be defined. Then I just wrap
> > the standby code in an '#ifndef NO_STANDBY_ON_SHUTDOWN..#endif'
> > block.
>
> Unless Andre agrees the change is required in the new IDE they won't be
> going in.
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2002-09-14 20:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-14 18:28 Alex Davis
2002-09-14 19:32 ` Alan Cox
2002-09-14 19:52 ` Alex Davis
2002-09-14 21:14 ` Andre Hedrick
2002-09-14 20:57 ` Andre Hedrick [this message]
2002-09-14 21:41 ` Alex Davis
2002-09-15 4:16 ` Andre Hedrick
2002-09-15 7:40 ` Alex Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.10.10209141342090.6925-100000@master.linux-ide.org \
--to=andre@linux-ide.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alex14641@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miquels@cistron.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®