mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andre Hedrick <andre@pyxtechnologies.com>
To: Douglas Gilbert <dougg@torque.net>
Cc: "J. E. J. Bottomley" <James.Bottomley@SteelEye.com>,
	Linus Torvalds <torvalds@transmeta.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: linux-2.4.18-modified-scsi-h.patch
Date: Mon, 18 Nov 2002 22:16:02 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.10.10211182138310.2779-200000@master.linux-ide.org> (raw)
In-Reply-To: <20021118171446.A28459@eng2.beaverton.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]


Greetings Doug et al.

Please consider the addition of this simple void ptr to the scsi_request
struct.  The addition of this simple void pointer allows one to map any
and all request execution caller the facility to search for a specific
operation without having to run in circles.  Hunting for these details
over the global device list of all HBA's is silly and one of the key
reasons why there error recovery path is so painful.


Scsi_Request    *req = sc_cmd->sc_request;
blah_blah_t     *trace = NULL;

trace = (blah_blah_t *)req->trace_ptr;


Therefore the specific transport invoking operations via the midlayer will
have the ablity to track and trace any operation.

It will save everyone headaches.

Cheers,


Andre Hedrick, CTO & Founder 
iSCSI Software Solutions Provider
http://www.PyXTechnologies.com/

[-- Attachment #2: Type: text/plain, Size: 599 bytes --]

--- linux/drivers/scsi/scsi.h.orig	2002-10-31 01:45:39.000000000 -0800
+++ linux/drivers/scsi/scsi.h	2002-10-31 01:46:31.000000000 -0800
@@ -667,8 +667,11 @@
 	unsigned short sr_sglist_len;	/* size of malloc'd scatter-gather list */
 	unsigned sr_underflow;	/* Return error if less than
 				   this amount is transferred */
+	void *trace_ptr;	/* capable of cmd-cmnd-error tracing */
 };
 
+#define MODIFIED_SCSI_H
+
 /*
  * FIXME(eric) - one of the great regrets that I have is that I failed to define
  * these structure elements as something like sc_foo instead of foo.  This would

       reply	other threads:[~2002-11-19  6:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20021118171446.A28459@eng2.beaverton.ibm.com>
2002-11-19  6:16 ` Andre Hedrick [this message]
2002-11-19  6:28   ` linux-2.4.18-modified-scsi-h.patch Jeff Garzik
2002-11-19  6:42     ` linux-2.4.18-modified-scsi-h.patch Andre Hedrick
2002-11-19 10:11   ` linux-2.4.18-modified-scsi-h.patch Douglas Gilbert
2002-11-19 12:16     ` linux-2.4.18-modified-scsi-h.patch Andre Hedrick
2002-11-19 18:40     ` linux-2.4.18-modified-scsi-h.patch Patrick Mansfield
2002-11-19 18:47       ` linux-2.4.18-modified-scsi-h.patch Jeff Garzik
2002-11-19 18:50         ` linux-2.4.18-modified-scsi-h.patch Andre Hedrick
2002-11-19 18:48       ` linux-2.4.18-modified-scsi-h.patch Andre Hedrick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.10.10211182138310.2779-200000@master.linux-ide.org \
    --to=andre@pyxtechnologies.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=dougg@torque.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®