mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andre Hedrick <andre@linux-ide.org>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: alan@redhat.com, linux-kernel <linux-kernel@vger.kernel.org>,
	Erik Andersen <andersen@codepoet.org>,
	trivial@rustcorp.com.au
Subject: Re: [2.5 patch] 2.4.21-rc1 pointless IDE noise reduction
Date: Sun, 18 May 2003 15:13:48 -0700 (PDT)	[thread overview]
Message-ID: <Pine.LNX.4.10.10305181510170.32050-100000@master.linux-ide.org> (raw)
In-Reply-To: <20030518130627.GC12766@fs.tum.de>


Just maybe people would like to know if there is a secret OS on the tail
of their drive, or the potential for one being there.

Go research EDDS BEER PARTIES and you will find out this is not a joke.

If the noise pisses you off turn down your kernel printk noise makers.
Better yet stub it out in your own kernel.

Do not remove items that have meaning or valid tests.

Erik, get over it and just live with a stub out.

Cheers,

On Sun, 18 May 2003, Adrian Bunk wrote:

> Below is a 2.5 version of the patch to remove 
> idedisk_supports_host_protected_area.
> 
> I've tested the compilation with 2.5.69-mm6.
> 
> cu
> Adrian
> 
> 
> --- linux-2.5.69-mm6/drivers/ide/ide-disk.c.old	2003-05-18 14:55:31.000000000 +0200
> +++ linux-2.5.69-mm6/drivers/ide/ide-disk.c	2003-05-18 14:56:17.000000000 +0200
> @@ -1064,18 +1064,6 @@
>  #endif /* CONFIG_IDEDISK_STROKE */
>  
>  /*
> - * Tests if the drive supports Host Protected Area feature.
> - * Returns true if supported, false otherwise.
> - */
> -static inline int idedisk_supports_host_protected_area(ide_drive_t *drive)
> -{
> -	int flag = (drive->id->cfs_enable_1 & 0x0400) ? 1 : 0;
> -	if (flag)
> -		printk(KERN_INFO "%s: host protected area => %d\n", drive->name, flag);
> -	return flag;
> -}
> -
> -/*
>   * Compute drive->capacity, the full capacity of the drive
>   * Called with drive->id != NULL.
>   *
> @@ -1101,8 +1089,6 @@
>  	drive->capacity48 = 0;
>  	drive->select.b.lba = 0;
>  
> -	(void) idedisk_supports_host_protected_area(drive);
> -
>  	if (id->cfs_enable_2 & 0x0400) {
>  		capacity_2 = id->lba_capacity_2;
>  		drive->head		= drive->bios_head = 255;
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

Andre Hedrick
LAD Storage Consulting Group


  reply	other threads:[~2003-05-18 22:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-18 13:06 Adrian Bunk
2003-05-18 22:13 ` Andre Hedrick [this message]
2003-05-18 23:08   ` Erik Andersen
2003-05-18 23:36   ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.10.10305181510170.32050-100000@master.linux-ide.org \
    --to=andre@linux-ide.org \
    --cc=alan@redhat.com \
    --cc=andersen@codepoet.org \
    --cc=bunk@fs.tum.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®