From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261901AbTJIHAn (ORCPT ); Thu, 9 Oct 2003 03:00:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261905AbTJIHAn (ORCPT ); Thu, 9 Oct 2003 03:00:43 -0400 Received: from astound-64-85-224-253.ca.astound.net ([64.85.224.253]:15891 "EHLO master.linux-ide.org") by vger.kernel.org with ESMTP id S261901AbTJIHAk (ORCPT ); Thu, 9 Oct 2003 03:00:40 -0400 Date: Wed, 8 Oct 2003 23:57:44 -0700 (PDT) From: Andre Hedrick To: Dave Jones cc: Srivatsa Vaddagiri , Alan Cox , lkcd-devel@lists.sourceforge.net, Linux Kernel Mailing List , linux-ide@vger.kernel.org Subject: Re: [PATCH] Poll-based IDE driver In-Reply-To: <20031008164851.GT29736@redhat.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org The rules are different in POLLing. Totally different state machine, and nothing seen here to date. You can not call any kernel services you can not depend upon. Using altstat is actually required but that is another day. Andre Hedrick LAD Storage Consulting Group On Wed, 8 Oct 2003, Dave Jones wrote: > On Wed, Oct 08, 2003 at 09:36:36AM -0700, Andre Hedrick wrote: > > > > Does not matter, priority is to get content to platter and the hell with > > everything else. > > I don't buy this. Without correct udelay()'s, how is code like this.. > > for (i = 0; i < 10; i++) { > dump_udelay(1); > if (OK_STAT((stat = hwif->INB(IDE_STATUS_REG)), good, bad)) > return 0; > } > > expected to work ? It won't wait for 10usec at all, but be over almost instantly. > Ramming commands at the drive before its status has settled doesn't strike > me as a particularly safe thing to do. > > Dave > > -- > Dave Jones http://www.codemonkey.org.uk >