mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Manik Raina <manik@cisco.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] fix for redefinition of jedec_probe_init
Date: Thu, 8 Nov 2001 12:39:32 +0530 (IST)	[thread overview]
Message-ID: <Pine.LNX.4.21.0111081237330.24010-100000@localhost.localdomain> (raw)

On inclusion of both these files (modules disabled) the build breaks.
This is because jedec_probe_init () is defined in both these files.

I am sending a patch which makes them static. Of course, there
is another option, since both these functions are doing the same
thing, we could delete one of them. 


diff -u -r /home/manik/linux/orig/linux/drivers/mtd/chips/jedec.c ./drivers/mtd/chips/jedec.c
--- /home/manik/linux/orig/linux/drivers/mtd/chips/jedec.c	Fri Oct  5 03:44:59 2001
+++ ./drivers/mtd/chips/jedec.c	Thu Nov  8 11:12:28 2001
@@ -873,7 +873,7 @@
    }
 }
 
-int __init jedec_probe_init(void)
+static int __init jedec_probe_init(void)
 {
 	register_mtd_chip_driver(&jedec_chipdrv);
 	return 0;
diff -u -r /home/manik/linux/orig/linux/drivers/mtd/chips/jedec_probe.c ./drivers/mtd/chips/jedec_probe.c
--- /home/manik/linux/orig/linux/drivers/mtd/chips/jedec_probe.c	Fri Oct  5 03:44:59 2001
+++ ./drivers/mtd/chips/jedec_probe.c	Thu Nov  8 11:12:31 2001
@@ -422,7 +422,7 @@
 	module: THIS_MODULE
 };
 
-int __init jedec_probe_init(void)
+static int __init jedec_probe_init(void)
 {
 	register_mtd_chip_driver(&jedec_chipdrv);
 	return 0;


             reply	other threads:[~2001-11-08  7:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-08  7:09 Manik Raina [this message]
2001-11-08 11:29 ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.21.0111081237330.24010-100000@localhost.localdomain \
    --to=manik@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®