From: <davej@suse.de>
To: Alan Cox <alan@redhat.com>
Cc: <becker@scyld.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] Hamachi not doing pci_enable before reading resources
Date: Wed, 7 Feb 2001 19:17:43 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.31.0102071914210.17543-100000@athlon.local> (raw)
Hi Alan,
Another driver not doing pci_enable_device() early enough.
Dave.
--
| Dave Jones. http://www.suse.de/~davej
| SuSE Labs
diff -urN --exclude-from=/home/davej/.exclude linux/drivers/net/hamachi.c linux-dj/drivers/net/hamachi.c
--- linux/drivers/net/hamachi.c Wed Feb 7 12:42:39 2001
+++ linux-dj/drivers/net/hamachi.c Wed Feb 7 19:09:31 2001
@@ -562,13 +562,14 @@
if (hamachi_debug > 0 && did_version++ == 0)
printk(version);
+ if (pci_enable_device(pdev))
+ return -EIO;
+
ioaddr = pci_resource_start(pdev, 0);
#ifdef __alpha__ /* Really "64 bit addrs" */
ioaddr |= (pci_resource_start(pdev, 1) << 32);
#endif
- if (pci_enable_device(pdev))
- return -EIO;
pci_set_master(pdev);
ioaddr = (long) ioremap(ioaddr, 0x400);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next reply other threads:[~2001-02-07 19:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-07 19:17 davej [this message]
2001-02-07 19:23 ` Jeff Garzik
2001-02-07 19:50 ` Richard B. Johnson
2001-02-07 20:05 ` Jeff Garzik
2001-02-07 20:30 ` Richard B. Johnson
2001-02-07 20:42 ` Alan Cox
2001-02-07 20:50 ` Gérard Roudier
2001-02-07 22:18 ` Richard B. Johnson
2001-02-07 19:43 davej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.31.0102071914210.17543-100000@athlon.local \
--to=davej@suse.de \
--cc=alan@redhat.com \
--cc=becker@scyld.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®