mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Mansfield <david@cobite.com>
To: Jens Axboe <axboe@suse.de>
Cc: <linux-kernel@vger.kernel.org>
Subject: comment typo for generic_make_request in 2.5.1-pre2?
Date: Tue, 27 Nov 2001 15:05:35 -0500 (EST)	[thread overview]
Message-ID: <Pine.LNX.4.33.0111271455560.4599-100000@admin> (raw)


Hi Jens et al,

Just looking at the bio changes in pre2 and I came across the comment for 
generic_make_request that says it may change bi_dev and/or bi_rsector.  I 
think the bi_rsector is supposed to be bi_sector (since the former no 
longer exists).  Here's a patch if in fact this is just a typo:

--- ll_rw_blk.c.orig	Tue Nov 27 14:57:40 2001
+++ ll_rw_blk.c	Tue Nov 27 15:02:23 2001
@@ -1041,7 +1041,7 @@
  *
  * generic_make_request and the drivers it calls may use bi_next if this
  * bio happens to be merged with someone else, and may change bi_dev and
- * bi_rsector for remaps as it sees fit.  So the values of these fields
+ * bi_sector for remaps as it sees fit.  So the values of these fields
  * should NOT be depended on after the call to generic_make_request.
  *
  * */

It's really no big deal, but I guess even the comments deserve to be 
correct. Anyway, this stuff is certainly fun reading!

David

-- 
/==============================\
| David Mansfield              |
| david@cobite.com             |
\==============================/



             reply	other threads:[~2001-11-27 20:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-27 20:05 David Mansfield [this message]
2001-11-28  7:33 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.33.0111271455560.4599-100000@admin \
    --to=david@cobite.com \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®